Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html not rendering in roundcube #5957

Closed
pcxmac opened this issue Sep 15, 2017 · 5 comments
Closed

html not rendering in roundcube #5957

pcxmac opened this issue Sep 15, 2017 · 5 comments

Comments

@pcxmac
Copy link

pcxmac commented Sep 15, 2017

system - ubuntu 16.04
php - 7.0.22-0ubuntu0.16.04.1
it's a very straightforward install, no real fancy stuff, but it is not working out of the box, i get basically the 'code' not a rendering of the html.

the release indicated by the CHANGELOG is 1.3.1

*plain text works fine

@alecpl
Copy link
Member

alecpl commented Sep 15, 2017

Are you talking about mail preview or composing? Any errors in log? Any errors in javascript console? Did you try with disabled all plugins? Did you try with different browser? What browser?

@pcxmac
Copy link
Author

pcxmac commented Sep 16, 2017

->mail preview
I use firefox or chrome-google and both yield the same result.

i used all the plugins originally, but then I disabled all of them, same result.

in firefox, under the browser console (JS) this error consistently pops up:
can't access dead object WebRequestCommon.jsm:49 typeMatches resource://gre/modules/WebRequestCommon.jsm:49:5 shouldRunListener resource://gre/modules/WebRequest.jsm:687:12 runChannelListener resource://gre/modules/WebRequest.jsm:878:14 examine resource://gre/modules/WebRequest.jsm:1048:7 observe

In the error log for roundcube...

nothing shows up at all, except for the early errors while establishing the service, i page through the emails in preview of the html code, nothing pops up under tail -f ./errors log is set to 1 or 4, same result (defaults).

I imagine that there is a process where the code is flipped from text to code inside the pane, but it's not happening. Any suggestions are welcome. It's been a while since i trouble-shot j/s & html5. not terribly interested, but if i get a clue/direction I can try.

@pcxmac
Copy link
Author

pcxmac commented Sep 16, 2017

well this fixed it, ... please acknowledge, probably needs to be considered in the next roll out.

http://www.roundcubeforum.net/index.php/topic,24510.0.html <<<<

(replace all?)
$node->tagName ==> $node->nodeName :: roundcube/program/lib/Roundcube/rcube_washtml.php
https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcube/rcube_washtml.php

@alecpl
Copy link
Member

alecpl commented Sep 16, 2017

That's interesting. DOMElement has tagName property defined, but DOMNode does not. Still I have no idea why that does not work for you.

@alecpl alecpl added this to the 1.3.2 milestone Sep 16, 2017
alecpl added a commit that referenced this issue Sep 17, 2017
…stems (#5957)

Consistently use $nodeName instead of $tagName property.
alecpl added a commit that referenced this issue Sep 17, 2017
…stems (#5957)

Consistently use $nodeName instead of $tagName property.
alecpl added a commit that referenced this issue Sep 17, 2017
…stems (#5957)

Consistently use $nodeName instead of $tagName property.
@alecpl
Copy link
Member

alecpl commented Sep 17, 2017

Fixed.

@alecpl alecpl closed this as completed Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants