fix wrong "text" parsing #5838
Closed
fix wrong "text" parsing #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accept lines containing dots only - I thing check position index should be $position, not $pos
|
Looks like you might be right, but do you have a sample sieve script that fails to parse correctly? I'd like to add a test for this. |
alecpl
added a commit
that referenced
this pull request
Jul 3, 2017
alecpl
added a commit
that referenced
this pull request
Jul 3, 2017
|
Nevermind, I fixed this in 8b61d6a. |
|
Great, you were fast. Just one thing - should not $position be incremented once more in case line ends with "\r\n"? Honestly I have not checked this practically, but length of "\r\n" is 2 symbols, not 1 symbol like in case of simple "\n", so the $position value may be wrong in this case. Please see my original pull request. |
alecpl
added a commit
that referenced
this pull request
Jul 3, 2017
alecpl
added a commit
that referenced
this pull request
Jul 3, 2017
|
You're right. I couldn't find a sample that breaks without this, but I fixed it anyway. |
alecpl
added a commit
that referenced
this pull request
Oct 12, 2017
alecpl
added a commit
that referenced
this pull request
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accept lines containing dots only - I thing check position index should be $position, not $pos