Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic CSS class in managesieve plugin impacts other plugins #5800

Closed
johndoh opened this issue Jun 17, 2017 · 2 comments
Closed

Generic CSS class in managesieve plugin impacts other plugins #5800

johndoh opened this issue Jun 17, 2017 · 2 comments

Comments

@johndoh
Copy link
Contributor

johndoh commented Jun 17, 2017

The managesieve plugin uses a CSS class a.button and because manageseive.css is always included when ever you are in the Settings section of Roundcube then the CSS can mistakenly be applied to other plugins. This means that other plugins have to first override the CSS from managesieve before adding their own if they also wish to use the CSS class a.button.

From managesieve/skins/larry/managesieve.css line 283

a.button
{
  margin: 0;
  padding: 0;
}
@alecpl
Copy link
Member

alecpl commented Jun 19, 2017

All a.button styles there should be prefixed with #filter-form .rowbuttons.

@alecpl alecpl self-assigned this Jun 19, 2017
@alecpl
Copy link
Member

alecpl commented Jun 28, 2017

Fixed.

@alecpl alecpl closed this as completed Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants