Fixes sieve parsing bug when comments contain empty lines #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpl
added a commit
that referenced
this pull request
Feb 20, 2017
alecpl
added a commit
that referenced
this pull request
Feb 20, 2017
|
Thanks for the patch. I fixed this in a cleaner way. |
ZiBiS
added a commit
to ZiBiS/roundcubemail
that referenced
this pull request
Mar 7, 2017
* 'master' of https://github.com/roundcube/roundcubemail: (46 commits) Plugin API: Call message_part_structure hook for sub-parts of multipart/alternative message (roundcube#5678) Enigma: Set micalg parameter to real hash algorithm used for signing Skip iconv for problematic ISO-2022-JP strings (roundcube#5668) Lock phpunit to version 5.7.x Fix/rephrase "unsaved changes" warning when cancelling a draft (roundcube#5610) Use stable release of Crypt_GPG 1.6 small fix for current group detection and add similar rules for group-delete Managesieve: Fix parser issue with empty lines between comments (roundcube#5657) Minimize unwanted message loading in preview frame on drag (roundcube#5616) Small code simplification Fix bug where it was too easy accidentally move a folder when using the subscription checkbox (roundcube#5655) also fix source in group create function check group id matches current one before changing the title Add rewrite rule to disable access to /vendor/bin folder in .htaccess (roundcube#5630) Fix update of group name in the contacts list header on group rename (roundcube#5648) don't use env for group-rename action Add note about PinEntry issues with SELinux (roundcube#5620) Enigma: Fix handling of messages with nested PGP encrypted parts (roundcube#5634) Bring back lists buttons in TinyMCE toolbar Fix double http request regression (roundcube#5633) ...
ZiBiS
added a commit
to ZiBiS/roundcubemail
that referenced
this pull request
May 23, 2017
* 'master' of https://github.com/roundcube/roundcubemail: (53 commits) Bump version number Performance: Skip redundant LISTSCRIPTS command CS fixes Use pear/net_sieve instead of our fork as it's up-to-date and maintained by us now Enigma: Fix compatibility with assets_dir Update changelog, CS fixes strncasecmp() -> strcasecmp() Remove redundant border in About dialog Add test for roundcube#5657 Support AUTHENTICATE LOGIN for IMAP connections (roundcube#5563) Highlight listmenu button when focused + better button style Fix var name Remove redundant code Support LDAP GSSAPI authentication (roundcube#5703) Add timezones.inc to transifex config Display loading message when going to another page (roundcube#5541) Add some accents and make some timezone names userfriendly Fix typo: s/UTC+/UTC/ Allow contacts without an email address (roundcube#5079) Update changelog ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample sieve filter set to reproduce the error:
Wihtout removing the empty line between
# simple commentand# another commentthe parser produces rubbish.