Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rcmail::get_instance() signature compatibility #5649

Closed
thomascube opened this issue Feb 17, 2017 · 4 comments
Closed

rcmail::get_instance() signature compatibility #5649

thomascube opened this issue Feb 17, 2017 · 4 comments
Labels
bug C: PHP backend minor
Milestone
1.2.4

Comments

@thomascube
Copy link
Member

We should fix the method signatures to match in order to avoid these warnings:

Warning: Declaration of rcmail::get_instance($env = '') should be compatible with rcube::get_instance($mode = 0, $env = '') in roundcube/program/include/rcmail.php on line 30
@thomascube thomascube added this to the 1.2.4 milestone Feb 17, 2017
@alecpl
Copy link
Member

alecpl commented Feb 17, 2017

As I see it is already fixed in 1.2.

@thomascube
Copy link
Member Author

Agreed with @alecpl

@thomascube
Copy link
Member Author

Oh, yes. Sorry for the noise and the confusing comment which was meant to go into another tab :-)

@thomascube
Copy link
Member Author

For the record: fixed in 1b39d9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: PHP backend minor
Projects
None yet
Milestone
1.2.4
Development

No branches or pull requests
2 participants
@alecpl @thomascube