Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates on contact group rename #5648

Closed
johndoh opened this issue Feb 16, 2017 · 2 comments
Closed

UI updates on contact group rename #5648

johndoh opened this issue Feb 16, 2017 · 2 comments

Comments

@johndoh
Copy link
Contributor

johndoh commented Feb 16, 2017

When you rename a contact group the name is updated in the groups list on the left hand side of the page but the name displayed at the top of the list of contents in the second column stays as the old one. I thought I could make a PR to improve this but the code for this is a little fractured and, possibly, out of date.

It looks like there are 2 JS functions rcmail.set_group_prop and rcmail.update_contact_group. update_contact_group is called when a group is renamed but only updates the groups list (and triggers JS event group_update). While set_group_prop is used when the groups contents is listed and sets the title in the second column (and triggers JS event groupupdate). I think that second JS event is wrong, I'm guessing it should be group_update, the same format as group_insert and group_delete. But also I'm wondering if these 2 JS functions shouldn't be combined into 1 that updates both the list and the title (if the group is open).

EDIT: On reflection I think that rcmail.set_group_prop should not trigger the update event at all since its only called on list and not update.

@alecpl
Copy link
Member

alecpl commented Feb 16, 2017

I think the groupupdate event should be removed and set_group_prop() should be called from update_contact_group().

@alecpl
Copy link
Member

alecpl commented Feb 17, 2017

Fixed.

@alecpl alecpl closed this as completed Feb 17, 2017
ZiBiS added a commit to ZiBiS/roundcubemail that referenced this issue Mar 7, 2017
* 'master' of https://github.com/roundcube/roundcubemail: (46 commits)
  Plugin API: Call message_part_structure hook for sub-parts of multipart/alternative message (roundcube#5678)
  Enigma: Set micalg parameter to real hash algorithm used for signing
  Skip iconv for problematic ISO-2022-JP strings  (roundcube#5668)
  Lock phpunit to version 5.7.x
  Fix/rephrase "unsaved changes" warning when cancelling a draft (roundcube#5610)
  Use stable release of Crypt_GPG 1.6
  small fix for current group detection and add similar rules for group-delete
  Managesieve: Fix parser issue with empty lines between comments (roundcube#5657)
  Minimize unwanted message loading in preview frame on drag (roundcube#5616)
  Small code simplification
  Fix bug where it was too easy accidentally move a folder when using the subscription checkbox (roundcube#5655)
  also fix source in group create function
  check group id matches current one before changing the title
  Add rewrite rule to disable access to /vendor/bin folder in .htaccess (roundcube#5630)
  Fix update of group name in the contacts list header on group rename (roundcube#5648)
  don't use env for group-rename action
  Add note about PinEntry issues with SELinux (roundcube#5620)
  Enigma: Fix handling of messages with nested PGP encrypted parts (roundcube#5634)
  Bring back lists buttons in TinyMCE toolbar
  Fix double http request regression (roundcube#5633)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants