Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature placed incorrectly #5642

Closed
ondras opened this issue Feb 13, 2017 · 1 comment
Closed

Signature placed incorrectly #5642

ondras opened this issue Feb 13, 2017 · 1 comment

Comments

@ondras
Copy link

ondras commented Feb 13, 2017

Configuration:

  • Firefox 51
  • top_posting: true,
  • sig_below: false,
  • plaintext editing

When replying to an e-mail, the signature is inserted below the cited text. I believe that the culprit is https://github.com/roundcube/roundcubemail/blob/master/program/js/editor.js#L539, as the get_caret_pos function returns a large number that corresponds to the end of the message. Both setlectionStart and selectionEnd DOM properties of the <textarea> node are the same (equal to .value.length), meaning the caret is collapsed to the end of the text area.

Why does this code path even respect caret position? I would expect the settings above to result in sig being always inserted at the top...

@alecpl
Copy link
Member

alecpl commented Feb 13, 2017

Sounds like a duplicate of #5628.

@alecpl alecpl closed this as completed Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants