-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rcube_imap.delete_folder(): proper sequence #5466
Comments
Actually RFC says precissely:
So, it looks that there's more than just the order. |
sure. and the "recursive delete tree bottom up" approach allows to avoid various misinterpretations of the "RFC command DELETE inferior case" altogether |
Fixed. |
it seems there is still a problem (did not test): |
That should not be a problem. |
* upstream/master: Fix bug where it wasn't possible to store more that 2MB objects in memcache/apc (roundcube#5452) Added memcache_max_allowed_packet and apc_max_allowed_packet settings assword: Added possibility to nicely handle password epiration from other plugins (roundcube#5468) Fix bug where IMAP password could be exposed via error message (roundcube#5472) Fix bug where deleting folders with subfolders could fail in some cases (roundcube#5466) Support HTML input to rcube_text_editor.replace() (roundcube#5456) Set smtp options in sample config as they are required now Optimize image size Bump database version Better icon and CSS styles for PGP-related attachments (roundcube#5301 and roundcube#5279) Add icons for pgp-keys and php-encrypted attachments (roundcube#5301 and roundcube#5279) Update changelog Fix flickering of header topline in min-mode (roundcube#5426) Do not show inline images of unsupported mimetype (roundcube#5463) SQL, upgrade: increase session table ip field size for IPv6 addresses
currently
rcube_imap.delete_folder()
:https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcube/rcube_imap.php#L3295
when used for deleting in the middle of the branch, produces errors with dovecot v 2.2.25, and leaves empty 'lost' directories in server file system hierarchy, due to
leaf
delete happening afterstem
delete;proper sequence is "recursive delete tree bottom up" or
leaf
beforestem
, i.e.:https://github.com/random-cuber/contextmenu_folder/blob/master/contextmenu_folder.php#L595
The text was updated successfully, but these errors were encountered: