Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

responses: externalize rcube_webmail.insert_response() #5457

Closed
Andrei-Pozolotin opened this issue Oct 4, 2016 · 3 comments
Closed

responses: externalize rcube_webmail.insert_response() #5457

Andrei-Pozolotin opened this issue Oct 4, 2016 · 3 comments
Labels
C: Plugin API enhancement
Milestone
1.3-beta

Comments

@Andrei-Pozolotin
Copy link

while developing
https://github.com/random-cuber/responses

we were forced to replace rcube_webmail.insert_response() as follows
https://github.com/random-cuber/responses/blob/master/responses.js#L147

since there is no provision for php hook :
https://github.com/roundcube/roundcubemail/blob/master/program/include/rcmail.php#L376

nor is there js event listener / hook provision :
https://github.com/roundcube/roundcubemail/blob/master/program/js/app.js#L4354

please expose a legitimate way to inject responses template processor from a plugin
@Andrei-Pozolotin Andrei-Pozolotin mentioned this issue Oct 4, 2016
Closed
@alecpl
Copy link
Member

alecpl commented Oct 8, 2016

I think it should be solved with a hook in get_compose_responses(). However, maybe we should implement html responses first, then it would look completely different, because e.g. we'd not get all responses at once, but one by one.

@alecpl alecpl added this to the later milestone Oct 8, 2016
alecpl added a commit that referenced this issue Oct 29, 2016
@alecpl
Plugin API: Added get_compose_responses hook (#5457)
e3b61cd
@alecpl alecpl modified the milestones: 1.3-beta, later Oct 29, 2016
@alecpl
Copy link
Member

alecpl commented Oct 29, 2016

Done.

@alecpl alecpl closed this as completed Oct 29, 2016
@Andrei-Pozolotin
Copy link
Author

thank you

ZiBiS added a commit to ZiBiS/roundcubemail that referenced this issue Nov 8, 2016
@ZiBiS
Merge branch 'master' of https://github.com/roundcube/roundcubemail
d63c1a1 
* 'master' of https://github.com/roundcube/roundcubemail: (24 commits)
  Fix recognizing Sent folder on search if current folder has been changed by plugins in meantime
  CS improvements, _xor() method replaced with an anonymous function
  Fix style of Save button in password form (larry)
  Fix so templating system does not mess with external (e.g. email) content (roundcube#5499)
  Make "Add contact" image/text ignored when copying/selecting recipients in main headers (roundcube#5103)
  Fix redundant keep-alive/refresh after session error on compose page (roundcube#5500)
  Icons alignment fix
  Get rid of "popupmessage" class
  Warn about too many disclosed recipients in composed email [max_disclosed_recipients] (roundcube#5132) Allow to omit a subject when sending an email (roundcube#5068)
  identity_select: Support Received header (roundcube#5085)
  Fix error checking on get_script() result + some CS fixes
  Fix missing contact ID for contacts from non-sql addressbooks
  Remove "@Version @package_version@"
  Removed unused moxieplayer.swf
  CS fixes, use $this instead of local variable
  Plugin API: Added get_compose_responses hook (roundcube#5457)
  Enigma: Support GnuPG 2.1 (roundcube#5313)
  Better handling of rcube_text_editor.replace()'s input argument, some simplification
  GnuPG 2.1: Support password prompt on private key import
  GnuPG 2.1: Support password input on private key export
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Plugin API enhancement
Projects
None yet
Milestone
1.3-beta
Development

No branches or pull requests
2 participants
@alecpl @Andrei-Pozolotin