calling Auth_SASL::factory() w/ Auth_SASL 1.0.6

[philfry]

Hi,

I'm getting deprecation warnings for Auth_SASL::factory():

PHP Deprecated:  Non-static method Auth_SASL::factory() should not be called statically
  in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap_generic.php on line 578

this should fix it:

--- roundcubemail-1.2.1/program/lib/Roundcube/rcube_imap_generic.php.nonstatic
+++ roundcubemail-1.2.1/program/lib/Roundcube/rcube_imap_generic.php
@@ -575,7 +575,7 @@ class rcube_imap_generic
                     $user  = '';
                 }

-                $auth_sasl = Auth_SASL::factory('digestmd5');
+                $auth_sasl = (new Auth_SASL)->factory('digestmd5');
                 $reply     = base64_encode($auth_sasl->getResponse($authc, $pass,
                     base64_decode($challenge), $this->host, 'imap', $user));

Kind regards

Philippe

[alecpl]

The same code in used in Net_Sieve and Net_SMTP. I suppose it would be good to fix this upstream ticket http://pear.php.net/bugs/bug.php?id=21033.

[alecpl]

It was fixed where I could. Net_SMTP PR need to be merged.