Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely blank text part confuses some mail clients #5283

Closed
thomascube opened this issue May 29, 2016 · 4 comments
Closed

Completely blank text part confuses some mail clients #5283

thomascube opened this issue May 29, 2016 · 4 comments
Labels
bug minor
Milestone
1.2.1

Comments

@thomascube
Copy link
Member

If you compose a blank mail with html, some mail clients (e.g. Gmail, iOS Mail) will display the MIME attachment delineation text instead of blank space.
@thomascube
Copy link
Member Author

thomascube commented May 29, 2016 •
edited
Loading

The problem seems more to be on the Gmail side which apparently converts the (correctly) sent Content-Type: multipart/alternative; header into Content-Type: text/html if no actual content is found...

thomascube added a commit that referenced this issue May 29, 2016
@thomascube
Avoid sending completely empty text parts for multipart/alternative m…
4489441 
…essages (#5283)
@thomascube thomascube modified the milestones: 1.2.1, 1.1.6 May 29, 2016
@thomascube
Copy link
Member Author

Let's do some more testing before back-porting the change to 1.2 and 1.1

alecpl added a commit that referenced this issue Jun 28, 2016
@alecpl
Don't create multipart/alternative messages with empty text/plain part (
0ae4001 
#5283)
alecpl pushed a commit that referenced this issue Jun 28, 2016
@thomascube @alecpl
Avoid sending completely empty text parts for multipart/alternative m…
334b339 
…essages (#5283)
alecpl added a commit that referenced this issue Jun 28, 2016
@alecpl
Don't create multipart/alternative messages with empty text/plain part (
cd04cf4 
#5283)
@alecpl
Copy link
Member

alecpl commented Jun 28, 2016

Skipping blank text part is good anyway. Improved the change and cherry-picked to 1.2.

@alecpl alecpl modified the milestones: 1.2.1, 1.1.6 Jul 19, 2016
alecpl pushed a commit that referenced this issue Jul 19, 2016
@thomascube @alecpl
Avoid sending completely empty text parts for multipart/alternative m…
f1d80c6 
…essages (#5283)
alecpl added a commit that referenced this issue Jul 19, 2016
@alecpl
Don't create multipart/alternative messages with empty text/plain part (
2551019 
#5283)

Conflicts:
	CHANGELOG
	program/steps/mail/sendmail.inc
alecpl pushed a commit that referenced this issue Jul 19, 2016
@thomascube @alecpl
Avoid sending completely empty text parts for multipart/alternative m…
7b37ef8 
…essages (#5283)
alecpl added a commit that referenced this issue Jul 19, 2016
@alecpl
Don't create multipart/alternative messages with empty text/plain part (
f1ca20d 
#5283)

Conflicts:
	CHANGELOG
	program/steps/mail/sendmail.inc
@alecpl
Copy link
Member

alecpl commented Jul 19, 2016

I backported these changes to 1.0 and 1.1 as it sounds as a major issue. Not sure we should release them yet, as we stopped supporting 1.1, and 1.0 contains only two fixes.

@alecpl alecpl closed this as completed Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug minor
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
2 participants
@alecpl @thomascube