Enigma: Mail containing text + PGP encrypted part is not decrypted

[rcubetrac]

Reported by devotedmystic on 5 Jan 2016 07:16 UTC as Trac ticket #1490633

If there is other text before

-----BEGIN PGP MESSAGE-----

or after

-----END PGP MESSAGE-----

decryption fails. It seems Roundcube cannot extract/handle correctly the PGP part.

I tested the same message in Gmail with Mailvelope and it works. So, it's a Roundcube decryption error.

Migrated-From: http://trac.roundcube.net/ticket/1490633

[rcubetrac]

Severity changed by devotedmystic on 5 Jan 2016 07:18 UTC

normal => critical

[rcubetrac]

Comment by @alecpl on 5 Jan 2016 07:48 UTC

Are you using Enigma plugin or Mailvelope? What client creates such messages? Could you provide a sample (at least the structure) message?

[rcubetrac]

Severity changed by @alecpl on 5 Jan 2016 07:48 UTC

critical => major

[rcubetrac]

Milestone changed by @alecpl on 5 Jan 2016 07:48 UTC

later => 1.2-RC

[rcubetrac]

Comment by devotedmystic on 5 Jan 2016 08:17 UTC

I removed the "^" (check the symbol, because it is not displaying correctly in this page) in this line (enigma_engine.php):

else if (preg_match('/"^"-----BEGIN PGP MESSAGE-----/', $body)) {

And it works. But the text before is not displayed after decryption.

    function parse_plain(&$p)
    {
        $part = $p[       // exit, if we're already inside a decrypted message
        if (in_array($part->mime_id, $this->encrypted_parts)) {
            return;
        }
        // Get message body from IMAP server
        $body = $this->get_part_body($p['object']('structure'];
), $part->mime_id);
        // @TODO: big message body could be a file resource
        // PGP signed message
        if (preg_match('/"^"-----BEGIN PGP SIGNED MESSAGE-----/', $body)) {
            $this->parse_plain_signed($p, $body);
        }

        // PGP encrypted message
//        else if (preg_match('/"^"-----BEGIN PGP MESSAGE-----/', $body)) {
        else if (preg_match('/-----BEGIN PGP MESSAGE-----/', $body)) { // Extra text was impeding decryption
            $this->parse_plain_encrypted($p, $body);
        }
    }

[rcubetrac]

Comment by @alecpl on 27 Jan 2016 08:59 UTC

I couldn't find any standard for this, but e.g. Enigmail can handle such messages (with warning that only part of the body was encrypted). So, we should support this too, I suppose.

[rcubetrac]

Summary changed by @alecpl on 27 Jan 2016 08:59 UTC

Mail containing text + PGP encrypted part is not decrypted

Enigma: Mail containing text + PGP encrypted part is not decrypted

[alecpl]

Fixed.