Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session_start(): Session callback expects true/false return value #4948

Closed
rcubetrac opened this issue Dec 28, 2015 · 6 comments
Closed

session_start(): Session callback expects true/false return value #4948

rcubetrac opened this issue Dec 28, 2015 · 6 comments

Comments

@rcubetrac
Copy link

Reported by implodedok on 28 Dec 2015 12:14 UTC as Trac ticket #1490624

Using version 1.2-beta (which is not in the version dropdown list here on trac), I get the following warnings in my PHP error log:

PHP Warning: session_start(): Session callback expects true/false return value in /var/www/roundcubemail/program/lib/Roundcube/rcube_session.php on line 129

I am running php7 with php-fpm. Roundcube itself seems to work fine. This could be a compatibility issue with php7.

Keywords: php warning session callback
Migrated-From: http://trac.roundcube.net/ticket/1490624

@rcubetrac
Copy link
Author

Comment by @alecpl on 28 Dec 2015 15:16 UTC

I don't have this warning on PHP7. What session driver are you using? What PHP version?

@rcubetrac
Copy link
Author

Comment by @alecpl on 28 Dec 2015 15:26 UTC

Ok, I see that rcube_session::gc() does not return boolean. This may be the issue.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 28 Dec 2015 15:26 UTC

later => 1.2-RC

@rcubetrac
Copy link
Author

Comment by @alecpl on 28 Dec 2015 16:08 UTC

Confirmed and fixed in d72e5af.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 28 Dec 2015 16:08 UTC

new => closed

@rcubetrac
Copy link
Author

Comment by implodedok on 28 Dec 2015 16:34 UTC

Thanks for the prompt response & patch! :-) I'll apply the changeset above to my 1.2-beta installation, will let you know if the warning appears again. Also, for reference, I'm using the default php session handler (files in /var/lib/php/session).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant