Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in showing eml attachments (in 1.1.3) #4937

Closed
rcubetrac opened this issue Dec 14, 2015 · 18 comments
Closed

regression in showing eml attachments (in 1.1.3) #4937

rcubetrac opened this issue Dec 14, 2015 · 18 comments
Labels
bug C: MIME parsing
Milestone
1.1.4

Comments

@rcubetrac
Copy link

Reported by combr on 14 Dec 2015 06:50 UTC as Trac ticket #1490606

I upgrade 0.9.2 to 1.1.3, and found a regression in showing rfc822 attachments inline.

In a "undelivered message" standard letter I see in 0.9.2 two attachments: "delivery report" and original message in it. Original message (base64-encoded) shown correctly in preview pane.

In 1.1.3 a letter of same type with same attachments (delivery report with original message) NOT shown correctly: in preview pane i see a plain source text of original message (base64 coding) instead decoded message. 1.1.3 ignores headers when show "original message" attachment, it is:
Content-Type: text/html; charset=windows-1251
Content-Transfer-Encoding: base64

But this headers
From: rs_support@...
To: byk.bykov2016@...
Subject: =?Windows-1251?B?y+j37fvpIOrg4ejt5fI=?=
not ignored and show correctly in messahe header.

rc 1.1.3 uses php ver 5.4.45 , 0.9.2 uses php 5.4.4, other are same. I attach two screenshots.

Migrated-From: http://trac.roundcube.net/ticket/1490606
@rcubetrac
Copy link
Author

Comment by combr on 14 Dec 2015 07:07 UTC

addition: if .eml extension linked, for example, to thunderbird (windows 7) I can download and open that eml attachment correctly in thunderbird window.

attach full source code of letter.

@rcubetrac
Copy link
Author

Comment by @alecpl on 14 Dec 2015 08:04 UTC

Confirmed. Works in 1.0, but not in 1.1 and above.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 14 Dec 2015 08:04 UTC

later => 1.1.4

@rcubetrac
Copy link
Author

Comment by @alecpl on 14 Dec 2015 09:14 UTC

Fixed in 6463b66.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 14 Dec 2015 09:14 UTC

new => closed

@rcubetrac
Copy link
Author

Comment by combr on 14 Dec 2015 09:19 UTC

Thanks for fast answer, checking and fixing. Can you generate a patch for 1.1.3 for me?

@rcubetrac
Copy link
Author

Comment by @alecpl on 14 Dec 2015 09:33 UTC

Ouch, failed to push. Now it's there. 6463b66

@rcubetrac
Copy link
Author

Comment by combr on 14 Dec 2015 09:54 UTC

I insert this code in this file manually, and it affected the view, but not decode it correctly. I attach new screenshot.

@rcubetrac
Copy link
Author

Comment by combr on 14 Dec 2015 10:10 UTC

original letter decoded is HTML and looks like:

Content-Type: text/html; charset=windows-1251
Content-Transfer-Encoding: base64

<HTML><BODY> !<BR>    <a href="https://*******.ru
/Private/loginPage.jsp">   ""</a>.<BR>  
*****69  *****JB<BR><BR>     
         .<BR><BR> 
  .     .<BR><BR> 
</BODY></HTML>

@rcubetrac
Copy link
Author

Comment by @alecpl on 14 Dec 2015 10:21 UTC

What do you mean, it looks like this. Is the body base64 encoded or not in the email source? Works for me.

@rcubetrac
Copy link
Author

Comment by combr on 14 Dec 2015 10:26 UTC

body not base64 encoded, but it wrong decoded (see screenshot). It contains only dots, spaces, quotes and hyperlinks instead normal original html letter with text.

@rcubetrac
Copy link
Author

Status changed by combr on 14 Dec 2015 10:26 UTC

closed => reopened

@rcubetrac
Copy link
Author

Comment by @alecpl on 14 Dec 2015 10:33 UTC

How the source looks like? It should be base64-encoded if Content-Transfer-Encoding: base64 is specified.

@rcubetrac
Copy link
Author

Comment by @alecpl on 14 Dec 2015 10:34 UTC

Also, what you provided looks like UTF-8 not windows-1251.

@rcubetrac
Copy link
Author

Comment by combr on 14 Dec 2015 10:42 UTC

it contains only ASCII symbols, and lose all win-1251 symbols.
look at it - instead " !" it show only "!"
instead "" it show "" with hyperlink
" pxx08044069 lAuJJB" converts to "pxx08044069 lAuJJB"
and so on

no, it cyrillic windows-1251 in original, thunderbird show it correct.
I rechecked this.

@rcubetrac
Copy link
Author

Comment by @alecpl on 14 Dec 2015 11:19 UTC

Ok, got it. Fixed in bb6002f.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 14 Dec 2015 11:19 UTC

reopened => closed

@rcubetrac
Copy link
Author

Comment by combr on 14 Dec 2015 12:14 UTC

Yes, we got it! :)
Now it works correctly, regression fixed. Big thanks!

@rcubetrac rcubetrac added this to the 1.1.4 milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: MIME parsing
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
1 participant
@rcubetrac