Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Importing..." message does not hide on error #4840

Closed
rcubetrac opened this issue Jun 4, 2015 · 2 comments
Closed

"Importing..." message does not hide on error #4840

rcubetrac opened this issue Jun 4, 2015 · 2 comments

Comments

@rcubetrac
Copy link

Reported by @alecpl on 4 Jun 2015 18:13 UTC as Trac ticket #1490422

When messages upload fails the "Importing, please wait..." message does not disappear. Following patch fies the issue:

diff --git a/program/js/app.js b/program/js/app.js
index dc5c8c1..b3e4632 100644
--- a/program/js/app.js
+++ b/program/js/app.js
@@ -1268,7 +1268,7 @@ function rcube_webmail()

         $('input[name="_unlock"]', form).val(importlock);

-        if (!(flag = this.upload_file(form, 'import'))) {
+        if (!(flag = this.upload_file(form, 'import', importlock))) {
           this.set_busy(false, null, importlock);
           if (flag !== false)
             alert(this.get_label('selectimportfile'));
@@ -4179,7 +4179,7 @@ function rcube_webmail()
   };

   // upload (attachment) file
-  this.upload_file = function(form, action)
+  this.upload_file = function(form, action, lock)
   {
     if (!form)
       return;
@@ -4221,6 +4221,9 @@ function rcube_webmail()
           if (!content.match(/display_message/))
             ref.display_message(ref.get_label('fileuploaderror'), 'error');
           ref.remove_from_attachment_list(e.data.ts);
+
+          if (lock)
+            ref.set_busy(false, null, lock);
         }
         // Opera hack: handle double onload
         if (bw.opera)

Migrated-From: http://trac.roundcube.net/ticket/1490422

@rcubetrac
Copy link
Author

Comment by @alecpl on 5 Jun 2015 17:28 UTC

Fixed in 42f8aba.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 5 Jun 2015 17:28 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant