Blank image in html_signature when saving identity changes

[rcubetrac]

Reported by v tomas on 28 May 2015 07:41 UTC as Trac ticket #1490412

Hello,

Editing an identity, if I try to attach an image (I've tried jpeg or png) with html_signature enabled and save the changes then the image that I've just attached is blank. If I inspect the image element there is no "src" attribute.

Investingating a little I've found that modifying the variable "$regexp" (line 210) from the function "rcmail_attach_images" inside the file /var/www/roundcube/program/steps/settings/save_identity.inc it works fine.

old value: '/\s(poster|src)\s*=\s*[value: '/\s(poster|src)\s*=\s*[\'"](\'"]*\S+upload-display\S+file=rcmfile([0-9]+)[\s\'"]*/'

new)*\S+upload-display\S+file=rcmfile(\w+)[\s\'"]*/'

NOTE: I'm not a PHP developer. I don't know if it's the best fix.

Environment:
OS: Debian 7.8 (with updates)
php: 5.4.39
apache: 2.2.22

Keywords: html_signature
Migrated-From: http://trac.roundcube.net/ticket/1490412

[rcubetrac]

Comment by @alecpl on 28 May 2015 08:24 UTC

Confirmed.

[rcubetrac]

Milestone changed by @alecpl on 28 May 2015 08:24 UTC

later => 1.1.2

[rcubetrac]

Comment by @alecpl on 28 May 2015 08:35 UTC

Fixed in c044d30.

[rcubetrac]

Status changed by @alecpl on 28 May 2015 08:35 UTC

new => closed