BMP attachments display warnings

[rcubetrac]

Reported by netesa on 19 Feb 2015 07:25 UTC as Trac ticket #1490282

Roundcube assumes .bmp files to have MIME-type image/bmp. However, it is not officially registered at IANA and on many systems it is detected as image/x-ms-bmp. This triggers a warning in Roundcube while trying to open the attachment: "Expected: image/bmp (.bmp); found: image/x-ms-bmp".

Migrated-From: http://trac.roundcube.net/ticket/1490282

[rcubetrac]

Comment by @alecpl on 19 Feb 2015 07:41 UTC

That might be mime detection related issue, but anyway, I think we could ignore the "conflict" if both expected and found type have "image/" prefix. That should not be a security issue, I suppose.

[rcubetrac]

Milestone changed by @alecpl on 19 Feb 2015 07:41 UTC

later => 1.1.1

[rcubetrac]

Comment by @alecpl on 19 Feb 2015 12:45 UTC

Fixed in 4a2a62d.

[rcubetrac]

Status changed by @alecpl on 19 Feb 2015 12:45 UTC

new => closed

[rcubetrac]

Comment by netesa on 20 Feb 2015 08:56 UTC

I still observe some problems with BMP files. I'm not quite sure if this is a problem with Roundcube or mime detection issue on my server, however, now the warning is slightly different: "Expected: image/bmp (.bmp); found: image/bmp".

[rcubetrac]

Comment by @alecpl on 20 Feb 2015 09:11 UTC

Hmm... What if you change the line

$valid_extension = !$file_extension || in_array($file_extension, (array)$extensions); 

to

$valid_extension = !$file_extension || empty($extensions) || in_array($file_extension, (array)$extensions); 

?

[rcubetrac]

Comment by netesa on 20 Feb 2015 09:15 UTC

With that change it is OK, no warning :)

[rcubetrac]

Comment by @alecpl on 20 Feb 2015 09:42 UTC

Fixed in 45256e8.