Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managesieve sometimes breaks display #4689

Closed
rcubetrac opened this issue Oct 29, 2014 · 18 comments
Closed

Managesieve sometimes breaks display #4689

rcubetrac opened this issue Oct 29, 2014 · 18 comments

Comments

@rcubetrac
Copy link

Reported by GieltjE on 29 Oct 2014 10:22 UTC as Trac ticket #1490125

The sieve plugin sometimes breaks the page display (using either default skin), the weird thing is that this only happens to some accounts.

Migrated-From: http://trac.roundcube.net/ticket/1490125

@rcubetrac
Copy link
Author

Comment by @alecpl on 29 Oct 2014 12:11 UTC

Is there any javascript error in browser error console? Does it happen in different browsers? Anything in logs? This is current git-master or what version?

@rcubetrac
Copy link
Author

Comment by GieltjE on 29 Oct 2014 12:21 UTC

  • The javascript console doesn't report any errors/other messages
  • It happens in all mayor browsers
  • This is the git master version

@rcubetrac
Copy link
Author

Comment by @alecpl on 29 Oct 2014 12:23 UTC

Does it happen in larry skin or classic only?

@rcubetrac
Copy link
Author

Comment by GieltjE on 29 Oct 2014 12:25 UTC

It happens on both skins, the larry skin just shows it a bit different (just two empty sliders).

@rcubetrac
Copy link
Author

Comment by GieltjE on 29 Oct 2014 12:49 UTC

Added a screenshot of the vacation setting, as far as I can judge it's breaking the same way.

@rcubetrac
Copy link
Author

Comment by @alecpl on 29 Oct 2014 13:05 UTC

You'll have the same effect if managesieve.css file will not be loaded (or added to the page). Please, check this.

@rcubetrac
Copy link
Author

Comment by GieltjE on 29 Oct 2014 13:14 UTC

Indeed the managesieve_mail.css file doesn't get loaded, the weird thing is that it does load on some accounts (if it doesn't load the managesieve_mail.css rel is missing in the page source).

Edit:

The account's that do or do not work are consistent, they are always the same ones (even after clearing the session table).

@rcubetrac
Copy link
Author

Comment by @alecpl on 29 Oct 2014 16:29 UTC

the managesieve_mail.css is supposed to be loaded in mail task, in settings it should load managesieve.css. The code which adds them to the page is here https://github.com/roundcube/roundcubemail/blob/master/plugins/managesieve/managesieve.php#L87

Please, investigate why it does not load css file(s). It doesn't look like Roundcube issue.

@rcubetrac
Copy link
Author

Comment by GieltjE on 30 Oct 2014 10:30 UTC

I have found the underlying difference, if the user hasn't made an active choice for their skin it tries to load /roundcube/plugins/managesieve/skins/ /managesieve.css.

It looks like local_skin_path() doesn't default back to the default skin defined in the config.

@rcubetrac
Copy link
Author

Comment by @alecpl on 30 Oct 2014 11:19 UTC

Interesting, but I'm unable to reproduce even if I reset user preferences in database and remove 'skin' setting form config files(s).

@rcubetrac
Copy link
Author

Comment by GieltjE on 30 Oct 2014 11:26 UTC

Using MySQL:
Not working preferences (also empty): a:1:{s:17:"message_threading";a:1:{s:7:"Reports";b:0;}}
Working preferences: a:2:{s:4:"skin";s:5:"larry";s:9:"date_long";s:9:"Y-m-d H:i";}

Switching between those Preferences values makes the skin load or fail.
It appears that if no skin is set in the database value the fallback to the skin defined in the roundcube main config file is ignored.

@rcubetrac
Copy link
Author

Comment by @alecpl on 30 Oct 2014 11:27 UTC

Do you maybe have deprecated skin_path setting in config?

@rcubetrac
Copy link
Author

Comment by @alecpl on 30 Oct 2014 11:31 UTC

I can reproduce with setting skin to an invalid value 'larry/'.

@rcubetrac
Copy link
Author

Comment by @alecpl on 30 Oct 2014 11:34 UTC

Please, confirm commit 1ffab0a fixes the issue.

@rcubetrac
Copy link
Author

Comment by GieltjE on 30 Oct 2014 11:43 UTC

Works like a charm, thanks for the support!

But doesn't the fix in program/lib/Roundcube/rcube_plugin.php revert to larry instead of the theme specified via $config [ 'skin' ] ?

@rcubetrac
Copy link
Author

Comment by @alecpl on 30 Oct 2014 11:49 UTC

No, it fallbacks to larry if skin is not set at all. However, 'skin' here is never empty, so I reverted this part of the fix in db357b4.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 30 Oct 2014 11:49 UTC

new => closed

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 30 Oct 2014 11:49 UTC

later => 1.0.4

@rcubetrac rcubetrac added this to the 1.0.4 milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant