-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managesieve sometimes breaks display #4689
Comments
Comment by @alecpl on 29 Oct 2014 12:11 UTC Is there any javascript error in browser error console? Does it happen in different browsers? Anything in logs? This is current git-master or what version? |
Comment by GieltjE on 29 Oct 2014 12:21 UTC
|
Comment by @alecpl on 29 Oct 2014 12:23 UTC Does it happen in larry skin or classic only? |
Comment by GieltjE on 29 Oct 2014 12:25 UTC It happens on both skins, the larry skin just shows it a bit different (just two empty sliders). |
Comment by GieltjE on 29 Oct 2014 12:49 UTC Added a screenshot of the vacation setting, as far as I can judge it's breaking the same way. |
Comment by @alecpl on 29 Oct 2014 13:05 UTC You'll have the same effect if managesieve.css file will not be loaded (or added to the page). Please, check this. |
Comment by GieltjE on 29 Oct 2014 13:14 UTC Indeed the managesieve_mail.css file doesn't get loaded, the weird thing is that it does load on some accounts (if it doesn't load the managesieve_mail.css rel is missing in the page source). Edit: The account's that do or do not work are consistent, they are always the same ones (even after clearing the session table). |
Comment by @alecpl on 29 Oct 2014 16:29 UTC the managesieve_mail.css is supposed to be loaded in mail task, in settings it should load managesieve.css. The code which adds them to the page is here https://github.com/roundcube/roundcubemail/blob/master/plugins/managesieve/managesieve.php#L87 Please, investigate why it does not load css file(s). It doesn't look like Roundcube issue. |
Comment by GieltjE on 30 Oct 2014 10:30 UTC I have found the underlying difference, if the user hasn't made an active choice for their skin it tries to load /roundcube/plugins/managesieve/skins/ /managesieve.css. It looks like local_skin_path() doesn't default back to the default skin defined in the config. |
Comment by @alecpl on 30 Oct 2014 11:19 UTC Interesting, but I'm unable to reproduce even if I reset user preferences in database and remove 'skin' setting form config files(s). |
Comment by GieltjE on 30 Oct 2014 11:26 UTC Using MySQL: Switching between those Preferences values makes the skin load or fail. |
Comment by @alecpl on 30 Oct 2014 11:27 UTC Do you maybe have deprecated skin_path setting in config? |
Comment by @alecpl on 30 Oct 2014 11:31 UTC I can reproduce with setting skin to an invalid value 'larry/'. |
Comment by GieltjE on 30 Oct 2014 11:43 UTC Works like a charm, thanks for the support! But doesn't the fix in program/lib/Roundcube/rcube_plugin.php revert to larry instead of the theme specified via $config [ 'skin' ] ? |
Status changed by @alecpl on 30 Oct 2014 11:49 UTC new => closed |
Milestone changed by @alecpl on 30 Oct 2014 11:49 UTC later => 1.0.4 |
Reported by GieltjE on 29 Oct 2014 10:22 UTC as Trac ticket #1490125
The sieve plugin sometimes breaks the page display (using either default skin), the weird thing is that this only happens to some accounts.
Migrated-From: http://trac.roundcube.net/ticket/1490125
The text was updated successfully, but these errors were encountered: