Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to execute a hook after imap login #4638

Closed
rcubetrac opened this issue Aug 6, 2014 · 9 comments
Closed

Option to execute a hook after imap login #4638

rcubetrac opened this issue Aug 6, 2014 · 9 comments

Comments

@rcubetrac
Copy link

Reported by peteraltmann on 6 Aug 2014 13:10 UTC as Trac ticket #1490025

Hi,
we are looking for a possibility to configure the execution of a hook after the imap login succeded. For testing we patched "/usr/share/roundcube/program/include/rcmail.php" of roundcube-core in the public function "imap_connect". It worked, but the hook execution is hardcoded. Do you plan such an option? Or please give us a hint, how do this for you to get it in a stable release?

Best regards
Peter Altmann

Keywords: hook
Migrated-From: http://trac.roundcube.net/ticket/1490025

@rcubetrac
Copy link
Author

Comment by @alecpl on 6 Aug 2014 13:29 UTC

0.7.2, really? What's the use-case for this? Can this be handled with other existing hook?

@rcubetrac
Copy link
Author

Comment by tanders on 6 Aug 2014 20:55 UTC

0.7.2 is the version shipped with Debian stable (wheezy). One use case is to send additional IMAP commands after IMAP login, e.g. to transmit the client (browser) IP address to satisfy operational and/or legal requirements.

@rcubetrac
Copy link
Author

Comment by @alecpl on 7 Aug 2014 06:15 UTC

You send ID command? It's parameters can be modified in 'storage_connect' hook (in rcube_imap::connect()). I'm not sure it is supported by 0.7.

@rcubetrac
Copy link
Author

Comment by tanders on 7 Aug 2014 06:40 UTC

IMAP ID information gets changed by the IMAP proxy (Dovecot) before being passed to the IMAP backend, so we're using a custom IMAP command that the IMAP proxy will forward unmodified. But again, the desired generic hook (for trunk) could be used to pass any (other) IMAP command.

@rcubetrac
Copy link
Author

Comment by @thomascube on 7 Aug 2014 15:13 UTC

New hook storage_connected implemented in f954922.
We use it for additional logging but I suppose it can be used for sending additional IMAP commands after login, too.

@rcubetrac
Copy link
Author

Status changed by @thomascube on 7 Aug 2014 15:13 UTC

new => closed

@rcubetrac
Copy link
Author

Milestone changed by @thomascube on 7 Aug 2014 15:13 UTC

later => 1.1-beta

@rcubetrac
Copy link
Author

Comment by tanders on 8 Aug 2014 07:00 UTC

Thank you. Would you also consider a backport patch for the 1.0.x branch if we supply it?

@rcubetrac
Copy link
Author

Keywords changed by tc marco on 20 Aug 2014 09:27 UTC

hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant