popupmenus closed scrollbar is clicked

[rcubetrac]

Reported by rocknob on 24 Apr 2014 11:08 UTC as Trac ticket #1489832

1. compose a message.
2. press the language selection button and scroll down to the end (or at the end, scroll up) by pressing the mousebutton

the selection will close immediately and you cant select a language for spellchecker.

scrolling down with mouse is no problem

Keywords: thomasb
Migrated-From: http://trac.roundcube.net/ticket/1489832

[rcubetrac]

Comment by @alecpl on 24 Apr 2014 18:10 UTC

This is true for all popupmenus with scrollbars. This can be fixed by using onclick event instead of onmouseup for body_mouseup function. I'm not sure such change will not break something, so must be well tested. Thomas, what do you think?

[rcubetrac]

Keywords changed by @alecpl on 24 Apr 2014 18:10 UTC

thomasb

[rcubetrac]

Milestone changed by @alecpl on 24 Apr 2014 18:10 UTC

later => 1.0.1

[rcubetrac]

Summary changed by @alecpl on 24 Apr 2014 18:10 UTC

Spellcheckinglanguage selection bug

popupmenus closed scrollbar is clicked

[rcubetrac]

Comment by @thomascube on 25 Apr 2014 15:15 UTC

That should actually be covered somehow by the rcube_mouse_is_over() check. Maybe that's where we should start investigating and fixing things. Unfortunately, on my Mac I don't have buttons to operate scroll bars...

[rcubetrac]

Comment by @thomascube on 25 Apr 2014 15:51 UTC

But it's much simple than that: when one clicked the scrollbar, the event target equals the popup menu contain. Otherwise the target is a child element. Thus checking target != obj.get(0) should do it. I still need to verify that theory on different browsers...

[rcubetrac]

Comment by @thomascube on 25 Apr 2014 16:15 UTC

Fixed in commit 8dc87e6.

[rcubetrac]

Status changed by @thomascube on 25 Apr 2014 16:15 UTC

new => closed

[rcubetrac]

Comment by rocknob on 28 Apr 2014 07:58 UTC

shure it is fixed ? i see it works in IE but not in Firefox ?

[rcubetrac]

Comment by @alecpl on 28 Apr 2014 08:09 UTC

Works for me in recent stable version of Firefox.

[rcubetrac]

Comment by rocknob on 28 Apr 2014 11:25 UTC

so i need no aply more than these two fixes? i will wait till 1.0.1 is out :)