Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery lost draft message ? #4529

Closed
rcubetrac opened this issue Apr 17, 2014 · 16 comments
Closed

Recovery lost draft message ? #4529

rcubetrac opened this issue Apr 17, 2014 · 16 comments

Comments

@rcubetrac
Copy link

Reported by L1Ntu on 17 Apr 2014 19:41 UTC as Trac ticket #1489818

After updating from 0.9.4 to 1.0.0 when i click to compose i have popup :


Recovering message
Founded early composed but not sended message.

Theme : ...
Saved : ...

Do u want to recover it ?


After any option (recover/delete/ignore) after some period of time it appears again...

Migrated-From: http://trac.roundcube.net/ticket/1489818

@rcubetrac
Copy link
Author

Comment by @alecpl on 18 Apr 2014 05:03 UTC

It appears again in the same compose window or when you go to compose again? Does it propose to recover the same message all the time?

It is a new feature in 1.0 that composed message is saved in local storage of the browser. The popup should be showed if previously composed message wasn't saved to drafts nor sent (e.g. because of lost Internet connection).

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 18 Apr 2014 05:03 UTC

later => 1.0.1

@rcubetrac
Copy link
Author

Comment by L1Ntu on 18 Apr 2014 07:47 UTC

It appears when i click compose again.
Ye, it propose to recover the same massages all the time (someone have 1 msg, someone have 5-10 msgs)

Where it saves them ? And is it possible to turn off this feature in config, coz i realy dont need it(Got working TS 24/7 * 6months). Or maybe i can clean this storage ? Got about 30+ workers and 20+ have this annoying problem.

Thanks

@rcubetrac
Copy link
Author

Comment by @alecpl on 18 Apr 2014 09:40 UTC

This is stored in the browser. Maybe you can disable it in the browser but not in Roundcube. When this dialog is displayed you have three buttons:

  • Restore (restores the message)
  • Delete (deletes the saved message from the storage, so the dialog will not be displayed again for this message)
  • Ignore (ignores the message, but will ask again when you visit compose page).

So, for me you need to use Delete button. Works for me. Does it ask again for the same message even if you use Delete button?

ps. Maybe we should indeed add another button: "Do not save drafts locally" or sth.

@rcubetrac
Copy link
Author

Comment by L1Ntu on 18 Apr 2014 12:19 UTC

Anyway, even if i click on any of this 3 buttons (restore,delete,ignore) it appears again...

Would be great if there will be option in config or switch in usr profile

@rcubetrac
Copy link
Author

Comment by @alecpl on 23 Apr 2014 07:03 UTC

What browser? Did you try with different browser?

@rcubetrac
Copy link
Author

Comment by @alecpl on 8 May 2014 12:24 UTC

I found one issue that might cause this. Saved messages aren't removed from the localStorage when you compose the message in new window and close that window. That might cause long list of saved messages. Steps to reproduce:
0. Use Firefox (install Firebug and FireStorage Plus! add-ones).

  1. Configure Roundcube to compose in new window
  2. Click Compose, write some letters, wait few seconds (see in Firebug that an entry to localStorage is added)
  3. Close browser window with compose page.
  4. Repeat steps 2-3.
  5. Close main browser window (wait until session expires or e.g. truncate session table).
  6. See that you have now many entries in localStorage.

Maybe we can fix this by removing the entry from localStorage in page unload event. See also related request #1489820.

@rcubetrac
Copy link
Author

Comment by L1Ntu on 24 May 2014 08:13 UTC

Yes. Most of my users use compose in new window !
Most of them use FF, but some one chrome / opera

@rcubetrac
Copy link
Author

Comment by aberglund on 11 Jun 2014 15:09 UTC

Sorry for creating redundant ticket #1489938, I missed the part about adding a "Do not save drafts locally" button when searching this issue. My organization strongly supports that addition, especially if it would be added into the config file as a global setting.

@rcubetrac
Copy link
Author

Comment by @alecpl on 8 Jul 2014 16:26 UTC

Fixed in d81539a. Feature request moved to #1489979.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 8 Jul 2014 16:26 UTC

new => closed

@rcubetrac
Copy link
Author

Comment by @alecpl on 9 Jul 2014 06:10 UTC

My fix "disables" effectively localStorage. Need better solution.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 9 Jul 2014 06:10 UTC

closed => reopened

@rcubetrac
Copy link
Author

Comment by @thomascube on 9 Jul 2014 08:54 UTC

New fix showing a warning message when closing the compose window with an unsaved message in 7e7e451.

@rcubetrac
Copy link
Author

Comment by @thomascube on 20 Jul 2014 12:05 UTC

Backported to release-1.0 branch in commit 007f1b4.

@rcubetrac
Copy link
Author

Status changed by @thomascube on 20 Jul 2014 12:05 UTC

reopened => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant