Popup blocker check

[rcubetrac]

Reported by rosali on 17 Feb 2014 07:19 UTC as Trac ticket #1489618

Please add a popup blocker check to app.js (lines 1738 ff.)

If 'extwin' is undefined then there should be an alert to ask user to disable a popup blocker.

Migrated-From: http://trac.roundcube.net/ticket/1489618

[rcubetrac]

Comment by @thomascube on 2 Mar 2014 17:09 UTC

Replying to rosali:

Please add a popup blocker check to app.js (lines 1738 ff.)

If 'extwin' is undefined then there should be an alert to ask user to disable a popup blocker.

We expect popup-blockers to display a notice to the user. At least that's what I see in all of the blockers I've been using.

And IMO it's the caller's obligation to handle undefined return values of rcmail.open_window()

[rcubetrac]

Comment by @thomascube on 2 Mar 2014 17:24 UTC

Reschedule feature request

[rcubetrac]

Milestone changed by @thomascube on 2 Mar 2014 17:24 UTC

1.0-stable => 1.1-beta

[rcubetrac]

Comment by rosali on 2 Mar 2014 18:23 UTC

I'm using Chrome for my daily browsing. I have overlooked the small popup blocker icon several times. IMO, an additional message when things go wrong (extwin is undefined) would be best.

[rcubetrac]

Comment by @alecpl on 25 Apr 2014 13:24 UTC

Checking extwin might be not enough in Chrome: http://stackoverflow.com/questions/8802409/how-do-i-detect-whether-popups-are-blocked-in-chrome

[rcubetrac]

Comment by @alecpl on 30 May 2014 08:53 UTC

I failed to do reliable blocker detection on Chrome and some blocker extensions. Simple check implemented in b408e0b.

[rcubetrac]

Status changed by @alecpl on 30 May 2014 08:53 UTC

new => closed