Forward Messages should include In-Reply-To & References Headers

[rcubetrac]

Reported by marcusm on 11 Feb 2014 16:41 UTC as Trac ticket #1489593

GMail and Thunderbird both do this, seems like a nice feature to add.

Originally from:

http://lists.roundcube.net/pipermail/users/2014-February/010350.html

Migrated-From: http://trac.roundcube.net/ticket/1489593

[rcubetrac]

Comment by marcusm on 11 Feb 2014 16:43 UTC

From: Aleksander 'A.L.E.C' Machniak

One thing to consider. It is possible to forward many messages in one
message. Should References and In-Reply-To be set in such a case? If so,
to what values?

I see Thunderbird puts all forwarded messages IDs in References, but
(only) one in In-Reply-To. That might be not what we want, but what's

the intended behaviour here I'm not sure.

[rcubetrac]

Severity changed by @alecpl on 12 Feb 2014 07:49 UTC

major => normal

[rcubetrac]

Milestone changed by @alecpl on 12 Feb 2014 07:49 UTC

later => 1.1-beta

[rcubetrac]

Comment by marcusm on 19 Mar 2014 22:18 UTC

I've created a patch on a fork: https://github.com/malcomm/roundcubemail

The only file that was changed: program/steps/mail/compose.inc

Please see this commit:

malcomm@0c88414

These changes were made to 0.9.5, but I applied just those changes to the master via this fork.

If you can please review, I'd like to get this fix in as soon as possible.

Thank you -- Marcus

[rcubetrac]

Comment by marcusm on 20 Mar 2014 15:11 UTC

New commit addressing:

This is wrong, we shouldn't set $COMPOSE[for forwards, we want $COMPOSE['forward_uid']('reply_uid']).

malcomm@71dc733

[rcubetrac]

Comment by @alecpl on 31 Mar 2014 17:32 UTC

Thanks for your work. Fixed in 73076d7.

[rcubetrac]

Status changed by @alecpl on 31 Mar 2014 17:32 UTC

new => closed

[rcubetrac]

Comment by netesa on 2 Apr 2014 06:38 UTC

There are two small problems with commit 73076d7:

1. $COMPOSE[= $msg_uid; line has been completely removed and consequently the replied mails are not flagged.
2. There is redundant $COMPOSE['reply_msgid']('reply_uid']) = $MSSAGE->headers->messageID; in line 184. Probably $COMPOSE['reply_uid'] = $msg_uid; should be in that line instead.

[rcubetrac]

Comment by @alecpl on 2 Apr 2014 06:50 UTC

You're right. Fixed in d0cb327.