Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 Detection #4397

Closed
rcubetrac opened this issue Nov 14, 2013 · 6 comments
Closed

IE11 Detection #4397

rcubetrac opened this issue Nov 14, 2013 · 6 comments

Comments

@rcubetrac
Copy link

Reported by jimbullington on 14 Nov 2013 20:34 UTC as Trac ticket #1489434

Roundcube 9 does not appear to be detecting IE11 as a version of IE - resulting in some undesired behavior.

I've added the following to common.js on my site and it seems to work:

function roundcube_browser() 
{

.
.
.

  this.ie = (document.all && !window.opera);
  this.ie4 = (this.ie && !this.dom);
  this.ie5 = (this.dom && this.appver.indexOf('MSIE 5')>0);
  this.ie8 = (this.dom && this.appver.indexOf('MSIE 8')>0);
  this.ie9 = (this.dom && this.appver.indexOf('MSIE 9')>0);
  this.ie7 = (this.dom && this.appver.indexOf('MSIE 7')>0);
  this.ie6 = (this.dom && !this.ie8 && !this.ie7 && this.appver.indexOf('MSIE 6')>0);

  // detect IE11 as IE
  this.ie11 = !!navigator.userAgent.match(/Trident\/7.0.*rv:11.0/);
  if (this.ie11) {
    this.ie = true;
  }
.
.
.

Migrated-From: http://trac.roundcube.net/ticket/1489434

@rcubetrac
Copy link
Author

Comment by @alecpl on 15 Nov 2013 09:20 UTC

Does (document.all && !window.opera) not return true on IE11?

@rcubetrac
Copy link
Author

Comment by @alecpl on 15 Nov 2013 09:46 UTC

Commit 741ddce should fix this, also in rcube_browser.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 15 Nov 2013 09:46 UTC

new => closed

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 15 Nov 2013 09:46 UTC

later => 1.0-beta

@rcubetrac
Copy link
Author

Comment by jimbullington on 15 Nov 2013 13:16 UTC

It does not - not even a binary. The problem is that this.mz ends up being true at the end of the detection.

@rcubetrac
Copy link
Author

Comment by @alecpl on 15 Nov 2013 14:43 UTC

Now I see they removed document.all. Should be fixed in f03ed8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant