Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larry skin date column width is too narrow to display a full date string #4354

Closed
rcubetrac opened this issue Oct 9, 2013 · 10 comments
Closed

Comments

@rcubetrac
Copy link

Reported by leeph on 9 Oct 2013 10:14 UTC as Trac ticket #1489368

By default the Larry skin 'Date' column is 125px (in /skins/Larry/mail.css) but this is too narrow to display a full date when it includes the year, month, day and time (as opposed to 'Today' or other shortened strings).

Increasing it to 155px allows the display of the entire date string - please can this change be merged into the next release.

Migrated-From: http://trac.roundcube.net/ticket/1489368

@rcubetrac
Copy link
Author

Comment by leeph on 9 Oct 2013 10:15 UTC

Under /skins/Larry/mail.css

#messagelist tr td.date {
width: 125px;
}

Please change to 155px.

@rcubetrac
Copy link
Author

Comment by angelitoes on 9 Oct 2013 12:04 UTC

I have no problem with 0.9.1. Am I missing something?
See attachment "date.PNG".

@rcubetrac
Copy link
Author

Comment by leeph on 9 Oct 2013 12:09 UTC

You have a different date format to me. Try changing it to the one as per attachment 'format.JPG' and see if you can reproduce the truncation on long (full) dates.

@rcubetrac
Copy link
Author

Comment by angelitoes on 9 Oct 2013 12:29 UTC

No problem. See "date2.PNG"

@rcubetrac
Copy link
Author

Comment by leeph on 9 Oct 2013 12:51 UTC

Ha, OK - now adjust your time format to the attached 'time.jpg' and re-assess.

Getting closer to the cause of the issue!

@rcubetrac
Copy link
Author

Comment by angelitoes on 9 Oct 2013 13:10 UTC

There we are.. It's the "AM/PM" what makes the column too narrow.
See "date3.PNG"

@rcubetrac
Copy link
Author

Comment by @alecpl on 9 Oct 2013 15:41 UTC

In current git-master it is set to 135px, but I can confirm that this is still not enough when time format contains AM/PM. From my tests at least 153px is needed.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 9 Oct 2013 15:41 UTC

later => 1.0-beta

@rcubetrac
Copy link
Author

Comment by @thomascube on 8 Nov 2013 12:03 UTC

Fixed in commit ccc2ace

@rcubetrac
Copy link
Author

Status changed by @thomascube on 8 Nov 2013 12:03 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant