Classic skin: Folder names not shortened/truncated (in dependence of splitter position)

[rcubetrac]

Reported by myfreexp on 2 Jul 2013 19:37 UTC as Trac ticket #1489220

In 0.9.x, folder names were shortened when the splitter has been moved too far to the left to fully display all folder names (e.g. "debian-sec...announce (524)").

In 1.0-git, folder names have instead been truncated ever since.

Since a few days, 0.9.x behaves the same as 1.0-git (folder names being truncated rather than shortened).

Whatever the desired behaviour is, it should be consistent in both versions.

Browser: IE 8.0.7601.17514

Keywords: folder names truncated splitter position
Migrated-From: http://trac.roundcube.net/ticket/1489220

[rcubetrac]

Comment by @alecpl on 3 Jul 2013 06:14 UTC

No, it don't need to be consistent, if we decide that the new "method" is better we keep it and do not apply it to old version. We'll investigate why 0.9 behaviour changed.

[rcubetrac]

Comment by @alecpl on 3 Jul 2013 07:53 UTC

Now I can confirm that in classic skin folder names aren't truncated (nor shortened) at all in both 0.9 and 1.0 (using Firefox browser). In Larry skin they are truncated.

[rcubetrac]

Summary changed by @alecpl on 3 Jul 2013 07:53 UTC

Shortened vs. truncated folder names (in dependence of splitter position)

Classic skin: Folder names not shortened/truncated (in dependence of splitter position)

[rcubetrac]

Comment by @alecpl on 3 Jul 2013 12:33 UTC

I forgot how it works. For performance reasons the truncation method is not executed if folders list contains more than 25 folders (IE) or 100 (other browsers). Also it doesn't work for names shorter than 6 characters. Finally, it is executed only when you finish dragging. See line 802 and 813 of skins/classic/functions.js. So, I didn't tested with IE yet, but I suppose you added more folders, that's why it stopped working.

[rcubetrac]

Comment by myfreexp on 3 Jul 2013 17:35 UTC

Just to avoid confusion with regards to the terms "shortened" and "truncated":

• "shortened" means to me a display such as: "debian-sec...announce (524)" (full folder name being "debian-security-announce (524)").
• "truncated" means to me that the very right part of the folder name is simply not visible (i.e. hidden), depending on the splitter position, so that it may be displayed like "debian-security-anno" for instance).

That being said, the behaviour mentioned above...

---

in classic skin folder names aren't truncated (nor shortened)

...can not exist, as the folder names have to be either shortened or truncated, if the splitter is dragged too far to the left to display the full folder name.

Anyway, indeed I added some temporary sub-folders the last days (although they are not visible as they are imploded, but Roundcube will most likely not be able to know their explode/implode status).

If this should be the reason for the changed behaviour in 0.9.x, that makes some sense. But then there is still a difference between 0.9.x and 1.0-git. If this difference is deliberate, that's fine - but I wasn't sure if it is/was deliberate. Is it...?

[rcubetrac]

Comment by @alecpl on 3 Jul 2013 18:13 UTC

In larry skin folders are "truncated" at the end in form of e.g. "debian-security-ann...". That's why my meaning of "truncated" is different. But you're right. It looks that selector that is supposed to skip invisible (collapsed) folders doesn't work. I'll see if we can do anything with that.
[the limit looks too low. My recent tests says in IE9 this procedure isn't slower than other non-IE browsers. So, I'll increase the limit to 50 for IE<=8, and set to 150 for other browsers.
[[BR]([BR]]
Also,)]
Finally, I don't see a difference in 1.0 and 0.9 behaviour. There's only difference in larry vs. classic.

[rcubetrac]

Comment by myfreexp on 3 Jul 2013 18:48 UTC

Understood (with regards to the meaning of "truncated"). I've never seen this truncation behaviour with classic skin, that's why...

With regards to the difference between 0.9.x and 1.0-git: As long as I had less than 25 folders, there definitely was a difference (in IE8): 0.9 shortened the folder names, 1.0 did neither shorten nor truncate them (as you confirmed yourself). Probably 1.0 Classic tried to "truncate" (in your sense) the folder names as in 1.0 Larry, but it just didn't work.

I'll check again as soon as I have reduced the number of folders (I'm going to remove all Squirrel mailing list folders pretty soon ;)).

On another issue: All of a sudden I'm seeing the domain trac.marketingxp.com in my browser URL (and even in the e-mail I received), rather than trac.roundcube.net. Did I miss something, has that been changed recently...?

[rcubetrac]

Comment by @alecpl on 3 Jul 2013 18:55 UTC

Replying to myfreexp:

On another issue: All of a sudden I'm seeing the domain trac.marketingxp.com in my browser URL

This is another domain of the same host. We used it some time ago when we changed host hosting the tracker. But it was more than month ago, so shouldn't happen now. Maybe browser is caching it or sth.

[rcubetrac]

Comment by myfreexp on 3 Jul 2013 19:17 UTC

No browser caching at all (at least not on my part, probably on yours), because as I said: The e-mail I received contained the following line in the signature:

Ticket URL: http://trac.marketingxp.com/ticket/1489220#comment:5

And I just clicked on it... See .eml attached.

[rcubetrac]

Comment by @alecpl on 4 Jul 2013 09:22 UTC

Ok. There were more issues in this. I fixed them in c3762a5 (git-master) and it's too heavy to backport the fixes to 0.9. Also the issue is not so important, in my opinion, to spend more time on it.

[rcubetrac]

Status changed by @alecpl on 4 Jul 2013 09:22 UTC

new => closed

[rcubetrac]

Milestone changed by @alecpl on 4 Jul 2013 09:22 UTC

0.9.3 => 1.0-beta