If contact_id divisible by 100, contact cannot be displayed

[rcubetrac]

Reported by vitek on 23 May 2013 15:33 UTC as Trac ticket #1489121

When the contact has contact_id divisible by 100 in contacts table, it is not possible to display the contact (you will receive an error about nonexistent contact or different contact is displayed). When you go to addressbook and you choose the group, you can see the contact (in the column Contacts), but when you click on it, you will receive the error message or different contact.

In program/steps/addressbook/func.inc there is a definition of a function rcmail_get_cids(). It contains these lines:

if (substr($id, -($got_source+1)) == "-$source") {
    $id = substr($id, 0, -($got_source+1));
}

In my case variable $source contains 0, variable $got_source contains 1 and when $id is divisible by 100, then you have "00" on the left side of the comparission. On the right side you have "-0". I dont exactly understand why those strings are equal ("00" and "-0"), they are probably for some reason converted to integer and then they are equal. After the condition succeeds, $id looses too digits from right (divided by 100) and the resulting cid is different so you will receive information about different contact (whose contact_id is original contact_id divided by 100) or you get an error message that contact doesnt exist.

Migrated-From: http://trac.roundcube.net/ticket/1489121

[rcubetrac]

Comment by @alecpl on 23 May 2013 16:26 UTC

Fixed in 6ae92aa

[rcubetrac]

Status changed by @alecpl on 23 May 2013 16:26 UTC

new => closed