Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying "additional plugins are required" message pops up in Firefox #4209

Closed
rcubetrac opened this issue May 21, 2013 · 7 comments
Closed

Comments

@rcubetrac
Copy link

Reported by oxan on 21 May 2013 18:31 UTC as Trac ticket #1489118

Since commit de6e225, RoundCube pops up the annoying "additional plugins are required to display all the media on this page" message in when pdf.js has been disabled in Firefox. Please remove the probing for a PDF plugin by adding an empty -tag, or add an option to disable it.

Migrated-From: http://trac.roundcube.net/ticket/1489118

@rcubetrac
Copy link
Author

Comment by @alecpl on 22 May 2013 06:37 UTC

Some versions of Firefox display "This PDF document might not be displayed correctly. with different viewer.". I suppose we'll need to remove this part of pdf plugin detection. I however am unable to reproduce any of these warnings.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 22 May 2013 06:37 UTC

later => 1.0-beta

@rcubetrac
Copy link
Author

Comment by oxan on 22 May 2013 18:28 UTC

Have you tried to disable pdf.js, either by setting pdfjs.disabled to true in about:config or setting the action for PDFs to "always ask" in Options > Applications? (I think I actually disabled pdf.js in another way, but I'm not sure which anymore...).

@rcubetrac
Copy link
Author

Comment by @alecpl on 23 May 2013 13:45 UTC

I removed the code for pdf detection in 1f19587.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 23 May 2013 13:45 UTC

new => closed

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 23 May 2013 13:45 UTC

1.0-beta => 0.9.2

@rcubetrac
Copy link
Author

Comment by oxan on 23 May 2013 14:19 UTC

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant