Issues found using static analysis

[rcubetrac]

Reported by rasmus on 5 May 2013 22:32 UTC as Trac ticket #1489086

These are the remaining issues to go along with #72

--------------------------------
File       : plugins/enigma/enigma.php:64
Reason     : UseUndeclaredVariable
Snippet    : $section
Line       : $this->ui->init($section);
--------------------------------
File       : plugins/enigma/lib/enigma_engine.php:384
Reason     : UseUndeclaredVariable
Snippet    : $error
Line       : 'message' => "Enigma plugin: " . $error->getMessage()
--------------------------------
File       : plugins/enigma/lib/enigma_engine.php:403
Reason     : UseUndeclaredVariable
Snippet    : $key
Line       : $result = $this->pgp_driver->decrypt($msg_body, $key, $pass);
--------------------------------
File       : plugins/enigma/lib/enigma_engine.php:403
Reason     : UseUndeclaredVariable
Snippet    : $pass
Line       : $result = $this->pgp_driver->decrypt($msg_body, $key, $pass);
--------------------------------
File       : plugins/password/drivers/pam.php:17
Reason     : UseUndeclaredVariable
Snippet    : $error
Line       : if (pam_auth($user, $currpass, $error, false)) {
--------------------------------
File       : plugins/password/drivers/pam.php:27
Reason     : UseUndeclaredVariable
Snippet    : $error
Line       : 'message' => "Password plugin: PAM authentication failed for user $user: $error"
--------------------------------
File       : plugins/password/password.php:171
Reason     : UseUndeclaredVariable
Snippet    : $res
Line       : $rcmail->output->command('display_message', $res, 'error');
--------------------------------
File       : program/lib/Roundcube/rcube_db.php:131
Reason     : UseUndeclaredVariable
Snippet    : $db_pconn
Line       : if ($db_pconn) {
--------------------------------
File       : program/lib/Roundcube/rcube_smtp.php:122
Reason     : UseUndeclaredVariable
Snippet    : $smtp_timeout
Line       : $result = $this->conn->connect($smtp_timeout);
--------------------------------

Migrated-From: http://trac.roundcube.net/ticket/1489086

[rcubetrac]

Comment by @alecpl on 6 May 2013 10:25 UTC

Fixed in ce89ecd

[rcubetrac]

Status changed by @alecpl on 6 May 2013 10:25 UTC

new => closed

[rcubetrac]

Milestone changed by @alecpl on 6 May 2013 10:25 UTC

later => 0.9.1