New install ignores db_table_xxxx settings.

[rcubetrac]

Reported by sactobob on 24 Apr 2013 23:10 UTC as Trac ticket #1489067

I wanted to combine two DBs, so modified all by db.inc.php settings to add the string extension "RC_" to all of the table names.

However, while roundcube uses these tables AFTER an install, the install process itself used to create tables IGNORES these settings. I verified this by taking a look at mysql.initial.sql and table creates are hard-coded, creating all the tables using initial defaults and not the entries in db.inc.php, which of course causes the install to fail thinking the DB is always uninitialized as that process correctly uses db.inc.php table names. IE:

test.php:

$db_read = $DB->query("SELECT count(*) FROM {$RCI->config['db_table_users']}");
if ($DB->is_error()) {

This is a disconnect between the automated installer and the table creation files, which causes confusion and disregards the flexibility of allowing the tables to be named in db.inc.php.

It's not readily apparent either, causing someone to click on the "initialize database" button only to find out all the wrong tables have been created, causing unnecessary administrative issues (IE having to go into the DB and delete or rename tables).

Keywords: sql installer fails
Migrated-From: http://trac.roundcube.net/ticket/1489067

[rcubetrac]

Milestone changed by @alecpl on 25 Apr 2013 05:51 UTC

later => 0.9.1

[rcubetrac]

Comment by @alecpl on 27 Apr 2013 16:33 UTC

Fixed in 399db1b with some refactoring which adds db_prefix option instead of many db_table__/db_sequence__ options. This is too big change for 0.9.

[rcubetrac]

Status changed by @alecpl on 27 Apr 2013 16:33 UTC

new => closed

[rcubetrac]

Milestone changed by @alecpl on 27 Apr 2013 16:33 UTC

0.9.1 => 1.0-beta