Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TinyMCE 4.0 #4168

Closed
rcubetrac opened this issue Apr 20, 2013 · 16 comments
Closed

Update to TinyMCE 4.0 #4168

rcubetrac opened this issue Apr 20, 2013 · 16 comments

Comments

@rcubetrac
Copy link

Reported by phs on 20 Apr 2013 12:00 UTC as Trac ticket #1489057

TinyMCE 4.0 Beta 1 has been released. It would be nice if it would be integrated in Roundcube 1.0.

Because this is a major upgrade of TinyMCE it could make sense to integrate it early in Roundcube 1.0 though it is still a beta release.

Keywords: tinymce
Migrated-From: http://trac.roundcube.net/ticket/1489057

@rcubetrac
Copy link
Author

Comment by @alecpl on 20 Apr 2013 14:42 UTC

I don't think it will be usable then. They removed some features and there's a lot of bugs. So, if we want to call 1.0 a most stable Roundcube release ever, we shouldn't include unstable TinyMCE in it. But let's decide later.

@rcubetrac
Copy link
Author

Comment by @alecpl on 17 May 2013 07:18 UTC

TinyMCE 4.0 doesn't support IE6. Larry skin also doesn't, but classic does. There's also possibility to update to jquery-ui 1.10 which also dropped IE6 support. So, we'd need to decide if we want to drop IE6 support completely in Roundcube 1.0 or after. I'd say after, because we want 1.0 to be a most stable release ever. Doing such updates will not keep it stable.

@rcubetrac
Copy link
Author

Comment by dennis1993 on 17 Jun 2013 09:49 UTC

TinyMCE 4 is now stable since 13th June 2013.

I would take on IE6 no more consideration. You drink but no 10 year old milk, right?
If one always takes on IE6 consideration, we will not move forward.
How many use Roundcube with IE6, you know? I think no one.
This is my opinion.

@rcubetrac
Copy link
Author

Comment by phs on 27 Jun 2013 19:22 UTC

TinyMCE 4.0.1 was released on 26 June 2013 and not even the first beta of Roundcube 1.0 has been released.

In my opinion TinyMCE 4.0 will be stable enough on the date, when Roundcube 1.0 final will be released.

@rcubetrac
Copy link
Author

Comment by phs on 8 Aug 2013 18:22 UTC

TinyMCE 4.0.3 was released on 8 August 2013.
jQuery 1.10.2 was released on 3 July 2013.

Using outdated software does not keep Roundcube stable, so +1 to upgrade both for Roundcube 1.0.

@rcubetrac
Copy link
Author

Comment by angelitoes on 4 Sep 2013 17:57 UTC

TinyMCE is getting more and more stable. Now version 4.0.5 is out.
I think that it'b better to include it in 0.9.x versions instead of waiting for 1.0 beta, so that we could start testing it as soon as posible. It's gonna be a very nice improvement for Roundcube once updated.

@rcubetrac
Copy link
Author

Milestone changed by angelitoes on 4 Sep 2013 17:57 UTC

1.0-beta => 0.9.5

@rcubetrac
Copy link
Author

Comment by @alecpl on 4 Sep 2013 17:58 UTC

Please, let developers decide or work on it on your own and provide patches.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 4 Sep 2013 17:58 UTC

0.9.5 => later

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 17 Oct 2013 08:38 UTC

later => 1.1-beta

@rcubetrac
Copy link
Author

Comment by @alecpl on 20 Jan 2014 17:49 UTC

I started working on this in tinymce4 branch. There's still some work to do on Roundcube and TinyMCE side.
http://www.tinymce.com/develop/bugtracker_view.php?id=6009
http://www.tinymce.com/develop/bugtracker_view.php?id=6646

@rcubetrac
Copy link
Author

Comment by @alecpl on 3 May 2014 06:56 UTC

Current status of tinymce4 branch. We're getting closer. Above errors has been fixed, TinyMCE updated to version 4.0.24. A few spellchecker related issues still left:

  1. non-working rcube_webmail's stop_spellchecking(), spellcheck_state(), spellcheck_lang(), spellcheck_lang_set(), spellcheck_resume() methods.
  2. Missing "Add to Dictionary" feature http://www.tinymce.com/develop/bugtracker_view.php?id=6234
  3. I have a feeling editor icons are too big for current Roundcube skins, maybe we need some css changes here, also we could consider using TinyMCE's menubar.

@rcubetrac
Copy link
Author

Comment by @alecpl on 3 May 2014 08:14 UTC

  1. Non-working drag-n-drop of images into the editor http://www.tinymce.com/develop/bugtracker_view.php?id=6898

@rcubetrac
Copy link
Author

Comment by @alecpl on 28 May 2014 13:53 UTC

Now only 4. is not fixed, but I decided to merge tinymce4 branch into the master.

@rcubetrac
Copy link
Author

Comment by @alecpl on 18 Jun 2014 18:44 UTC

Drag-n-drop fixed with update to TinyMCE 4.1.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 18 Jun 2014 18:44 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant