no orginal message included in reply

[rcubetrac]

Reported by javierwilson on 18 Apr 2013 13:57 UTC as Trac ticket #1489052

I just upgraded from 0.8.4 to 0.9.0, the only problem I notice so far is that no original message is included when I reply even though this option is selected.
I had a look at the code and line 565 in compose.inc :

else if ($compose_mode && ($compose_mode != RCUBE_COMPOSE_REPLY || $RCMAIL->config->get('reply_mode') != -1))

never returns true, because $RCMAIL->config->get('reply_mode') is boolean and not integer.

Since this is never true, it will always consider we are writing a new message and then it will not include any original message, of course.

I am using php 5.3.18.

Keywords: compose
Migrated-From: http://trac.roundcube.net/ticket/1489052

[rcubetrac]

Comment by @vbenincasa on 19 Apr 2013 02:55 UTC

It's working here, are you using the new config file (main.inc.php)?

// When replying:
// -1 - don't cite the original message
// 0  - place cursor below the original message
// 1  - place cursor above original message (top posting)
$rcmail_config['reply_mode'] = 1;

[rcubetrac]

Comment by @alecpl on 19 Apr 2013 06:06 UTC

Fixed in ca2c631.

[rcubetrac]

Status changed by @alecpl on 19 Apr 2013 06:06 UTC

new => closed

[rcubetrac]

Milestone changed by @alecpl on 19 Apr 2013 06:06 UTC

later => 0.9.1