Database errors when saving new contact, probably because of wrong variable name

[rcubetrac]

Reported by mgrum on 18 Apr 2013 13:57 UTC as Trac ticket #1489051

Hi

We keep getting database errors saying that column 'contactgroup_id' cannot be null. These errors seem to occur every time a user saves a new contact.

I tried to find out why this happens and I think I have found the reason, but correct me if I'm wrong.

In the file program/steps/addressbook/save.inc there is the following line:

`$CONTACTS->add_to_group($CONTACTS->group_id, $plugin['ids']('ids']);`

The));```

The wrong code is still there in the current git master.

_Migrated-From: http://trac.roundcube.net/ticket/1489051_

[rcubetrac]

Comment by @alecpl on 18 Apr 2013 14:40 UTC

Indeed, it should be $plugin['group_id']. The issue can be reproduce when adding a contact while a group is selected. The fix however should be investigated more, because we have already assigning to group functionality in rcube_contacts::insert(). So, one of these should be removed.

[rcubetrac]

Milestone changed by @alecpl on 18 Apr 2013 14:40 UTC

later => 0.9.1

[rcubetrac]

Comment by @alecpl on 19 Apr 2013 06:35 UTC

Fixed in 7652687.

[rcubetrac]

Status changed by @alecpl on 19 Apr 2013 06:35 UTC

new => closed