Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide or rename PGP/MIME signature "attachment" #3845

Closed
rcubetrac opened this issue Jul 19, 2012 · 6 comments
Closed

hide or rename PGP/MIME signature "attachment" #3845

rcubetrac opened this issue Jul 19, 2012 · 6 comments

Comments

@rcubetrac
Copy link

Reported by LeSpocky on 19 Jul 2012 12:48 UTC as Trac ticket #1488570

Without encryption plugin Roundcube shows a PGP/MIME signature as attachment. This is questionable from a technical point of view and confusing for users knowing nothing about encryption or working a lot with attachments.

Technically PGP/MIME sets the Content-Type: of a mail to multipart/signed. Unsigned mails with attachment usually have multipart/mixed set. Further: the content type of the signature itself is application/pgp-signature. So it should be easy to detect this. As far as the attachment symbol in the right most column of the mail list is concerned this already seems to be the case, so when looking for mails with attachment you won't find mails which are just signed.

However in mail view the signature is shown as attachment without type and the filename set in the mail which is signature.asc in many cases. With the above knowledge in mind this could be shown without the irrelevant file name but some descriptive name like PGP signature instead, minimizing confusion on user side.

Keywords: PGP
Migrated-From: http://trac.roundcube.net/ticket/1488570

@rcubetrac
Copy link
Author

Comment by LeSpocky on 31 Jul 2012 08:00 UTC

Mails signed with mutt and PGP/MIME are put together a little different, but the problem ist similar. See a signature (with MIME boundaries before and after):

--2oS5YaxWCcQjTEyO
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEABECAAYFAlAW+7sACgkQj7p3RMyHENCCFQCbBF+IvqjUxXCcPD9P4SukbdOd
zbYAnjoQxbhNnN75nVSU2oyhJ5WWzn6J
=N/3g
-----END PGP SIGNATURE-----

--2oS5YaxWCcQjTEyO--

Content type is also application/pgp-signature. This is shown like an attachment with the name "Part 2" instead of naming it "PGP/MIME signature".

@rcubetrac
Copy link
Author

Comment by @alecpl on 28 Dec 2012 14:36 UTC

With commit 830fd2e signatures are displayed as "Digital Signature". Would be nice to have a better icon for such attachments in Larry skin.

@rcubetrac
Copy link
Author

Owner changed by @alecpl on 28 Dec 2012 14:36 UTC

=> thomasb

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 28 Dec 2012 14:36 UTC

later => 0.9-beta

@rcubetrac
Copy link
Author

Comment by @thomascube on 24 Jan 2013 14:42 UTC

Icon added in commit 11d7e6c

@rcubetrac
Copy link
Author

Status changed by @thomascube on 24 Jan 2013 14:42 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants