attachment lost problem

[rcubetrac]

Reported by neglau on 12 Apr 2012 09:48 UTC as Trac ticket #1488422

When I sent multiple attachments in the same time, if two or more finished the upload in the exact same time, only one attachment is add to mail.
I think it's a concurrency probleme of the session var.
There is not return info of the problem and the list still contain all the attachments

Migrated-From: http://trac.roundcube.net/ticket/1488422

[rcubetrac]

Comment by @alecpl on 10 Jun 2012 09:04 UTC

Session race-condition would happen and it would be hard to get rid of them. However, we could return number of attachments in session on every upload request response. If the number is different than number of list rows we could send additional (verification) request and remove these which have disapeared from session.

[rcubetrac]

Comment by DmDS on 29 Jun 2012 10:51 UTC

same problem... fix it please!

[rcubetrac]

Comment by @alecpl on 4 Jul 2012 13:05 UTC

#1488554 marked as duplicate of this issue.

[rcubetrac]

Comment by @alecpl on 3 Aug 2012 07:24 UTC

In race-condition case the attachment isn't really removed but only attachment info is removed from the session. We could keep attachment info in browser and try to fix session when message is sent/saved.

[rcubetrac]

Milestone changed by @alecpl on 3 Aug 2012 07:24 UTC

later => 0.9-beta

[rcubetrac]

Comment by @thomascube on 27 Feb 2013 13:16 UTC

Maybe we should consider using array_merge_recursive() in rcube_session::_fixvars().

[rcubetrac]

Comment by @thomascube on 1 Mar 2013 23:15 UTC

I found a solution to reduce race conditions when uploading attachments synchronously. See commit f0a7159. Please test with latest checkout from git master.

[rcubetrac]

Comment by @thomascube on 10 Mar 2013 15:26 UTC

Was anybody able to test the latest git master version? I'd like to get some feedback before backporting the changes to the 0.9 release branch.

[rcubetrac]

Comment by @alecpl on 11 Mar 2013 08:28 UTC

It's hard to confirm the fix, because it's hard to confirm the issue by itself. With many tries I wasn't able to reproduce the issue again. I however found another case of it. I wasn't able to save the draft (and send) the message after: 1. upload many files, 2. while next bigger file uploading process is pending remove some of already uploaded files. It looks that after this some attachments already removed are still referenced in the session. This however is not 100% reproducible case, because hitting session race-condition is not simple.

[rcubetrac]

Comment by @thomascube on 4 Apr 2013 19:21 UTC

Fixed in release-0.9 branch with commits [d6cbdea..bd723e5].

[rcubetrac]

Status changed by @thomascube on 4 Apr 2013 19:21 UTC

new => closed