Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo "$config['enigma_pgp_homedir'] is not correctly escaped #295

Closed
logopk opened this issue Dec 3, 2024 · 1 comment · Fixed by #296
Closed

echo "$config['enigma_pgp_homedir'] is not correctly escaped #295

logopk opened this issue Dec 3, 2024 · 1 comment · Fixed by #296
Assignees
Labels
bug Something isn't working

Comments

@logopk
Copy link

logopk commented Dec 3, 2024

https://github.com/roundcube/roundcubemail-docker/blame/44bd59fa0ca61979b9577368681579873f962d84/fpm/docker-entrypoint.sh#L155

Compare the two lines!

docker-entrypoint.sh: echo "$config['spellcheck_uri'] = '${ROUNDCUBEMAIL_SPELLCHECK_URI}';" >> config/config.docker.inc.php
docker-entrypoint.sh: echo "$config['enigma_pgp_homedir'] = '/var/roundcube/enigma';" >> config/config.docker.inc.php

Startup with enigma fails since latest release and cannot be taken back as image is not versioned :-(

@pabzm pabzm added the bug Something isn't working label Dec 4, 2024
@pabzm pabzm self-assigned this Dec 4, 2024
@pabzm
Copy link
Member

pabzm commented Dec 4, 2024

Thank you for your report! This is indeed broken, sorry for that! Using the "enigma" plugin wasn't part of your tests, I'll change that.

image is not versioned

You can always refer to an image by ID, those change with every update. The ID of the latest image from before merging the broken change is 49d4016899c6508744e0c4b8a8c5f0c2f02f953ecef483b48c648eaa0d80be62, which you can reference with docker.io/roundcube/roundcubemail@sha256:49d4016899c6508744e0c4b8a8c5f0c2f02f953ecef483b48c648eaa0d80be62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants