Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Python code generation via rosidl generate CLI #123

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Feb 9, 2021

Built on top of ros2/rosidl#567. Connected to ros2/rosidl#565.

@hidmic hidmic requested a review from sloretz February 9, 2021 17:49
@hidmic
Copy link
Contributor Author

hidmic commented Feb 9, 2021

This works to a partial extent. Current generator code assumes the namespace structure in IDL files replicates their typical layout in the filesystem i.e. in a given ROS package within a subdirectory, to the point it uses either interchangeably. If the above convention is not respected, this code generator falls apart. I fear it's not the only code generator doing this.

@hidmic hidmic force-pushed the hidmic/rosidl-generate-py branch from 74b9d75 to 534167d Compare March 1, 2021 23:54
@ahcorde
Copy link
Contributor

ahcorde commented Mar 9, 2021

@hidmic
Copy link
Contributor Author

hidmic commented Mar 10, 2021

CI up to rosidl_generator_py:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic merged commit 97e8b08 into master Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/rosidl-generate-py branch March 10, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants