-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing <functional> include when building on 22.04 #350
Comments
Interestingly, we didn't see this because it doesn't fail on Ubuntu 24.04 for whatever reason. Regardless, as I wrote in #351 (comment) , we should fix this in upstream zenoh-cpp. |
Related PR eclipse-zenoh/zenoh-cpp#342 in zenoh_cpp |
Thanks, @ahcorde and @christophebedard! The PR looks good to me. By the way, I did a test within Iron and Humble dockers (22.04). It surprised me that it passed in Humble but failed in Iron. |
This was fixed by #353, so closing. |
I rebased #294 on
rolling
yesterday (Dec 18th, potentially after #347), and thenrmw_zenoh_cpp
started failing to build on my 22.04 system:Click to expand
Note this error message, which is repeated a few times:
It seems like something in zenoh uses
std::ref
without including<functional>
. Including<functional>
in some locations before<zenoh.hxx>
is included fixes the build:Note that
<zenoh.hxx>
is sometimes included before the STL includes. For example, seezenoh_utils.hpp
. In any case, this should probably instead be fixed in zenoh.The text was updated successfully, but these errors were encountered: