Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a better compression #57

Open
razr opened this issue Oct 6, 2022 · 5 comments
Open

use a better compression #57

razr opened this issue Oct 6, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@razr
Copy link
Member

razr commented Oct 6, 2022

I see that the image is compressed by the pigz from the original 3.9G to 1.5G, however it looks like that @carlossvg produces a release using xz compression which is only 932 MB

Before compression:
total 3.9G
-rw-r--r-- 1 runner docker 4.0G Sep 27 13:43 ubuntu-22.04.1-rt-ros2-arm64+raspi.img
+ cd out
+ echo 'After compression:'
+ pigz ubuntu-22.04.1-rt-ros2-arm64+raspi.img
After compression:
+ ls -lh .
total 1.5G
@razr razr added the enhancement New feature or request label Oct 6, 2022
@shuhaowu
Copy link
Member

shuhaowu commented Oct 6, 2022

Is that in CI? When I updated the release instructions, I opted to use xz as it produces a smaller image: https://github.com/ros-realtime/ros-realtime-rpi4-image/blob/master/docs/ReleaseImage.md

@razr
Copy link
Member Author

razr commented Oct 6, 2022

yes, it is in the GitHub workflow. I have built jammy https://github.com/razr/ros-realtime-rpi4-image/actions/runs/3135956272/jobs/5092263112
Right, if it would be nice to use xz, we can create an artifact and download it then.

@shuhaowu
Copy link
Member

shuhaowu commented Oct 6, 2022

Ah good point. We can switch the CI to using xz, but we also need to switch it to manual activation if that's the case (instead of automatically running on master push), because my experience running xz is that it is very slow and may consume a large amount of free CI time Github gives out for a particular account.

These should be simple changes but I don't have time to do that right now. Do you have time to create a PR and we can merge it?

@razr
Copy link
Member Author

razr commented Oct 6, 2022

I agree, I'm also using workflow_dispatch for the manual start in my other projects. I believe @LanderU wants to provide a patch.

@carlossvg
Copy link
Collaborator

Separate workflow in 2 steps:

  • build
  • compress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants