[REP-2001] Add colcon mixin to ros-dev-tools #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add python3-colcon-mixin to ros-dev-tools variant.
clalancette
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
This works for me as well. @Yadunund could you make a PR to https://github.com/ros-infrastructure/infra-variants/tree/latest/ros-dev-tools to update the .control and .spec files as well?
nuclearsandwich
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
No objection from me for two reasons:
- The only dependencies of colcon-mixin are colcon-core and python3-yaml and both are already part of the ros-dev-tools stack.
- This package does nothing unless a mixin argument is provided so this won't change behavior for anyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer I often rely on colcon mixin to pass build flags for my projects. For convenience, I'd like to propose adding this package to the
ros-dev-toolsvariant. If approved, I can follow up with changes needed to infra-variants.