-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minor updates to REP-147 #391
Add minor updates to REP-147 #391
Conversation
* Add as2_msgs * Specify base variable name in enums * Clarify timestamping for some messages Signed-off-by: Ryan Friedman <[email protected]>
* Ran the doc through spellcheck Signed-off-by: Ryan Friedman <[email protected]>
* If desired, as2_msgs can be incorated to the REP later Signed-off-by: Ryan Friedman <[email protected]>
* Must get it approved by MAVROS first Signed-off-by: Ryan Friedman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the extra changes. Ready for another pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small fix, then this is good to go.
Co-authored-by: Chris Lalancette <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
Purpose
Update/improve REP-147 with some minor changes or errors.
Changelist
Add as2_msgsSpecify base variable name in enums