Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minor updates to REP-147 #391

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Jan 31, 2024

Purpose

Update/improve REP-147 with some minor changes or errors.

Changelist

  • Add as2_msgs
  • Specify base variable name in enums
  • Clarify timestamping for some messages
  • Add missing package for Header in messages
  • Ran spellcheck and fixed all errors

* Add as2_msgs
* Specify base variable name in enums
* Clarify timestamping for some messages

Signed-off-by: Ryan Friedman <[email protected]>
* Ran the doc through spellcheck

Signed-off-by: Ryan Friedman <[email protected]>
rep-0147.rst Outdated Show resolved Hide resolved
rep-0147.rst Outdated Show resolved Hide resolved
* If desired, as2_msgs can be incorated to the REP later

Signed-off-by: Ryan Friedman <[email protected]>
* Must get it approved by MAVROS first

Signed-off-by: Ryan Friedman <[email protected]>
Copy link
Contributor Author

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the extra changes. Ready for another pass.

rep-0147.rst Outdated Show resolved Hide resolved
rep-0147.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix, then this is good to go.

rep-0147.rst Outdated Show resolved Hide resolved
Co-authored-by: Chris Lalancette <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@clalancette clalancette merged commit 0622e02 into ros-infrastructure:master Feb 6, 2024
1 check passed
@Ryanf55 Ryanf55 deleted the rep147-minor-updates branch February 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants