diff --git a/cran-comments.md b/cran-comments.md index 07a4bcf..933d994 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,30 +1,33 @@ -## Release v.0.6.1 +## Release v.0.6.2 -* Switch from stations_dl() function asks users to store data in cache (doesn't run during tests or setup) -* Don't test get_check() on CRAN because requires internet -* Uses vcr v1.0.2 to avoid test directory problems +* General changes to avoid CRAN policy violations, namely, errors when API is inaccessible: + * Use @examplesIf to ONLY run examples if resources are available + (I believe this was the problem that resulted in archival) + * Avoid tests where API calls used (even if mocking, or using vcr) + * Pre-compiled the vignettes which rely on the API +* Fixed minor bugs with new stations data +* Increased robustness to ECCC data changes ## Test environments -As of June 4th, 2021 +As of November 30th, 2021 -* ubuntu 20.04 - Local (4.1.0), GitHub Actions (devel, release, old release) -* OSX 10.15.7 - GitHub Actions (release) -* Windows Server - GitHub Actions (release, old release), winbuilder (devel) -* Debian GCC - rhub (release, patched, devel) -* Debian CLANG - rhub (devel) +* ubuntu 20.04 - Local (4.1.1), GitHub Actions (devel, release, old release) +* Windows Server - GitHub Actions (release), winbuilder (devel), rhub (devel, release, old release) +* OSX 11.6.1 - GitHub Actions (release) +* Solaris - rhub (release) * Fedora GCC - rhub (devel) * Fedora CLANG - rhub (devel) -* Solaris - rhub (release) +* Debian CLANG - rhub (devel) +* Debian GCC - rhub (release, patched, devel) + ## R CMD check results There were no ERRORs and no WARNINGs -2 NOTEs: +In addition to the NOTE that this is a new submission: -Debian GCC (patched and devel) had one NOTE: -* checking for future file timestamps ... NOTE - unable to verify current time +1 NOTEs: Solaris had one NOTEs: * checking top-level files ... NOTE diff --git a/release_script.R b/release_script.R index ef44e27..268eafb 100644 --- a/release_script.R +++ b/release_script.R @@ -15,7 +15,8 @@ dplyr::bind_cols(dplyr::select(hist, date_updated, checks), dplyr::filter(stringr::str_detect(date_updated, "2021-05-18")) %>% tidyr::unnest(checks) %>% dplyr::filter(status %in% c("WARN", "ERROR")) %>% - dplyr::select(-version, -tinstall, -tcheck, -ttotal, -any, -ok, -note, -warn, -error, -fail) %>% + dplyr::select(-version, -tinstall, -tcheck, -ttotal, -any, + -ok, -note, -warn, -error, -fail) %>% tidyr::unnest(details) %>% dplyr::pull(output) %>% unique() @@ -73,6 +74,10 @@ devtools::check(remote = TRUE, manual = TRUE, run_dont_test = TRUE, env_vars = list("NOT_CRAN" = "")) devtools::check(remote = TRUE, manual = TRUE, run_dont_test = TRUE) +# TURN OFF INTERNET AND TRY AGAIN +devtools::check(remote = TRUE, manual = TRUE, run_dont_test = TRUE, + env_vars = list("NOT_CRAN" = "")) + # Win builder devtools::check_win_release() devtools::check_win_devel() @@ -139,11 +144,7 @@ codemetar::write_codemeta() # pkgdown::build_reference() #pkgdown::build_articles(lazy = FALSE) -pkgdown::build_site(lazy = TRUE) -unlink("./vignettes/normals_cache/", recursive = TRUE) -unlink("./vignettes/articles/tidyhydat_cache/", recursive = TRUE) - -pkgdown::build_article(name = "articles/tidyhydat") +pkgdown::build_site() ## Push to github @@ -152,16 +153,12 @@ pkgdown::build_article(name = "articles/tidyhydat") ## Check Reverse Dependencies (are there any?) tools::dependsOnPkgs("weathercan") -revdepcheck::revdep_check(num_workers = 4) - -## Double check -old <- options(repos = c(CRAN = 'http://cran.rstudio.com')) -db <- available.packages() -pkgs <- rownames(db) -deps <- tools::package_dependencies(pkgs, db, which = 'all', reverse = TRUE) -deps$weathercan -options(old) - +# Check RavenR which suggests weathercan +weathercan::kamloops_day %>% + RavenR::rvn_rvt_write_met(metdata = ., + filenames = file.path(tempdir(), "rvn_rvt_metfile.rvt"), + filename_stndata = file.path(tempdir(), "met_stndata.rvt")) +# Warnings about NA okay ## Push to github