Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http://www.gutenberg.lib.md.us mirror working #82

Closed
jrdnbradford opened this issue Oct 17, 2024 · 1 comment · Fixed by #84
Closed

http://www.gutenberg.lib.md.us mirror working #82

jrdnbradford opened this issue Oct 17, 2024 · 1 comment · Fixed by #84

Comments

@jrdnbradford
Copy link
Contributor

jrdnbradford commented Oct 17, 2024

gutenberg_get_mirror has the following:

 # ...
  if (parsed$domain == "www.gutenberg.lib.md.us") {
    # Broken mirror. PG has been contacted. For now, replace:
    parsed$domain <- "aleph.gutenberg.org" # nocov
  }
# ...

The http://www.gutenberg.lib.md.us mirror seems to be up and running again. However, I also noticed this mirror is not listed on the official mirrors page.

There are a few things I think could be worth doing based on this:

  1. Remove the above code so that this mirror can be used.
  2. Document as part of the gutenberg_get_all_mirrors function that it retrieves officially listed mirrors and that other mirrors may exist.
  3. Perhaps add an unexported function to test whether or not a particular mirror is indeed a mirror and is working. Maybe by attempting to request GUTINDEX.zip from the mirror, and providing some sort of feedback? Maybe this should be a different PR than 1 and 2 if we want to do this.

@jonthegeek let me know what you think here.

@jonthegeek
Copy link
Collaborator

Yeah, go ahead and do 1 and 2, and write up 3 as a separate issue.

jrdnbradford added a commit to jrdnbradford/gutenbergr that referenced this issue Oct 17, 2024
This was referenced Oct 17, 2024
jonthegeek added a commit that referenced this issue Oct 30, 2024
* Allow formerly broken mirror (#82)

* Update docs

* Style & build docs.

* Tweak tests and messaging.

---------

Co-authored-by: Jon Harmon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants