Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export %>%? #61

Open
jonthegeek opened this issue Aug 30, 2024 · 2 comments
Open

Don't export %>%? #61

jonthegeek opened this issue Aug 30, 2024 · 2 comments

Comments

@jonthegeek
Copy link
Collaborator

Check how the tidyverse is dealing with %>% vs |>. We have a lot of %>% examples, but it doesn't feel like we should (always) export it.

@juliasilge
Copy link

The tidyverse still pretty much exports the magrittr pipe everywhere, like this:
https://github.com/tidyverse/purrr/blob/main/R/reexport-pipe.R

But uses the native pipe in examples via shenanigans like this:
https://github.com/tidyverse/purrr/pull/938/files#diff-63d8ec413a7b4fd902b8f0274a30155deb18ced670033ec5b09cbef42f9ec6ae

If you are only supporting to 'oldrel-1' in your GH action I would just switch everything to the native pipe.

@jonthegeek
Copy link
Collaborator Author

@juliasilge Thanks for the info! I keep forgetting that we're getting close to "base pipe is normal" timeframes! R 4.1.0 was released 2021-05-18, and, more importantly, that's 3.5 years ago, not last week 🙃

I haven't decided for sure how far back we need to go (I don't know for sure that our actions are "right" yet), but you raise something to definitely consider!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants