Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no results returned, package should still set hit count attribute (to 0) #56

Open
arvi1000 opened this issue Jun 6, 2024 · 3 comments
Open

When no results returned, package should still set hit count attribute (to 0) #56

arvi1000 opened this issue Jun 6, 2024 · 3 comments

Comments

@arvi1000
Copy link

arvi1000 commented Jun 6, 2024

At the moment when there are no results returned, md is set to NULL and the block is closed without setting the hit_count attr.

It would be good to add to add this line

attr(md, "hit_count") <- 0

before exiting
@arvi1000
Copy link
Author

arvi1000 commented Jun 6, 2024

I'd be happy to make this change, but I'm not sure of your contribution process. Should I fork the dev branch and then submit a PR?

@njahn82
Copy link
Member

njahn82 commented Jun 12, 2024 •
edited
Loading

Hi @arvi1000 Good catch, feel free to contribute a PR!

@arvi1000
Copy link
Author

Thanks. Filed a PR #58

@arvi1000 arvi1000 mentioned this issue Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njahn82 @arvi1000