Does KeepKey support GPG?

[doolio]

trezor-agent/agents/keepkey/setup.py

Line 7 in 3c911e9

description='Using KeepKey as hardware SSH/GPG agent',

Suggests it does.

trezor-agent/agents/keepkey/setup.py

Lines 35 to 37 in 3c911e9

	entry_points={'console_scripts': [
	'keepkey-agent = keepkey_agent:ssh_agent',
	]},

Yet, there appears to be no GPG entry points defined.

trezor-agent/agents/keepkey/keepkey_agent.py

Lines 1 to 5 in 3c911e9

	import libagent.gpg
	import libagent.ssh
	from libagent.device import keepkey
	ssh_agent = lambda: libagent.ssh.main(keepkey.KeepKey)

L1 imports the GPG module but there are then no gpg_tool or gpg_agent lambda function assignments like we have for the other hardware devices agents.

trezor-agent/libagent/device/keepkey.py

Line 10 in 3c911e9

if protocol not in {'ssh'}:

Suggests only SSH is supported.

[SlugFiller]

If you have one, you can simply enable the agent and test.

[doolio]

I only have a Trezor T.

[romanz]

@keepkeyjon IIUC, GPG wasn't supported initially on Keepkey - and was added only in keepkey/keepkey-firmware@95e41aa (#8), right?

[romanz]

FTR, Keepkey support was added in 5932a89 when it didn't support GPG.

[doolio]

That would explain the current state. Is it a matter of simply adding the entry points and the lambda functions I discuss above? If so I can submit such a PR for consideration.

[romanz]

Is it a matter of simply adding the entry points and the lambda functions I discuss above?

Not sure - it should also be tested with the latest Keepkey firmware, to make sure it indeed works.

[doolio]

Hmm ok. I only have a trezor T so can't help with such tests.

[SlugFiller]

The best motivation for contribution is needing it, or knowing someone who needs it. Worrying about support for a device you don't have and don't know anyone who has is noble, but most often not particularly productive.

[doolio]

You're right of course. I'm just highlighting potential issues where I see them.

[romanz]

@keepkeyjon IIUC, GPG wasn't supported initially on Keepkey - and was added only in keepkey/keepkey-firmware@95e41aa (#8), right?

CC: @keepkey @pastaghost @markrypto @markrypt0 @mrnerdhair @bgok (KeepKey maintainers)
Could you please let us know if GPG signature/decryption is supported by KeepKey?