onlykey-agent crashes on mac

[cizmazia]

See trustcrypto#38

When I run git pull with onlykey-agent, it works as expected except that macOS always opens a modal window "Python quit unexpectedly" with the crash report below.

Command:

$ onlykey-agent [email protected] -- git pull
Enter the 3 digit challenge code on OnlyKey to authorize <ssh://[email protected]|ed25519>
6 3 5
Already up to date.
[1]    26326 trace trap  onlykey-agent [email protected] -- git pull

$ onlykey-agent --version
onlykey-agent=1.1.14 lib-agent=1.0.5

Crash Report:

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               Python [28562]
Path:                  /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/Resources/Python.app/Contents/MacOS/Python
Identifier:            com.apple.python3
Version:               3.9.6 (3.9.6)
Build Info:            python3-124000000000000~2105
Code Type:             ARM-64 (Native)
Parent Process:        zsh [20509]
Responsible:           Terminal [1184]
User ID:               501

Date/Time:             2022-12-10 16:44:42.7602 +0100
OS Version:            macOS 13.0.1 (22A400)
Report Version:        12
Anonymous UUID:        6EC8A772-3004-3369-A691-867F7FD6E93F

Sleep/Wake UUID:       3A7AF147-1A15-4107-987B-A584FA041AAD

Time Awake Since Boot: 590000 seconds
Time Since Wake:       3774 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BREAKPOINT (SIGTRAP)
Exception Codes:       0x0000000000000001, 0x00000001a95d7e74

Termination Reason:    Namespace SIGNAL, Code 5 Trace/BPT trap: 5
Terminating Process:   exc handler [28562]

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   CoreFoundation                	       0x1a95d7e74 _CFAssertMismatchedTypeID + 112
1   CoreFoundation                	       0x1a95d7e6c _CFAssertMismatchedTypeID + 104
2   CoreFoundation                	       0x1a9497ccc CFRunLoopRemoveSource + 704
3   IOKit                         	       0x1ac59aa30 IOHIDDeviceUnscheduleFromRunLoop + 140
4   IOKit                         	       0x1ac59f8fc __IOHIDManagerDeviceApplier + 660
5   CoreFoundation                	       0x1a943f1d4 __CFSetApplyFunction_block_invoke + 28
6   CoreFoundation                	       0x1a943efec CFBasicHashApply + 148
7   CoreFoundation                	       0x1a943ef30 CFSetApplyFunction + 320
8   IOKit                         	       0x1ac59dfd4 __ApplyToDevices + 128
9   IOKit                         	       0x1ac59e110 IOHIDManagerUnscheduleFromRunLoop + 112
10  IOKit                         	       0x1ac59e034 IOHIDManagerClose + 44
11  hid.cpython-39-darwin.so      	       0x10557426c hid_exit + 32
12  hid.cpython-39-darwin.so      	       0x105574114 __pyx_pw_11cfunc_dot_to_py_27__Pyx_CFunc_int_______to_py_1wrap + 24
13  Python3                       	       0x1048c44b8 _PyObject_Call + 172
14  Python3                       	       0x1049a304c _PyEval_EvalFrameDefault + 24592
15  Python3                       	       0x1049a63d4 0x104884000 + 1188820
16  Python3                       	       0x1048c4678 _PyFunction_Vectorcall + 236
17  Python3                       	       0x1048c3d10 _PyObject_FastCallDictTstate + 272
18  Python3                       	       0x1048c4a58 _PyObject_Call_Prepend + 148
19  Python3                       	       0x104929e4c 0x104884000 + 679500
20  Python3                       	       0x1048c3ee8 _PyObject_MakeTpCall + 360
21  Python3                       	       0x1049a56d0 0x104884000 + 1185488
22  Python3                       	       0x1049a2dd4 _PyEval_EvalFrameDefault + 23960
23  Python3                       	       0x1048c4730 0x104884000 + 263984
24  Python3                       	       0x1048c689c 0x104884000 + 272540
25  Python3                       	       0x104a3d88c 0x104884000 + 1808524
26  Python3                       	       0x1049dfda8 Py_FinalizeEx + 72
27  Python3                       	       0x1049e0a80 Py_Exit + 20
28  Python3                       	       0x1049e5cc8 0x104884000 + 1449160
29  Python3                       	       0x1049e4b48 PyRun_SimpleFileExFlags + 912
30  Python3                       	       0x104a02df0 Py_RunMain + 1640
31  Python3                       	       0x104a03280 0x104884000 + 1569408
32  Python3                       	       0x104a03320 Py_BytesMain + 40
33  dyld                          	       0x1a906be50 start + 2544

[romanz]

Sorry, I don't have the HW to debug this issue.

[gitladen7]

Looks like it's this same issue: trezor/cython-hidapi#142