Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslib usage seems off #73

Open
justin-calleja opened this issue Apr 23, 2021 · 0 comments
Open

tslib usage seems off #73

justin-calleja opened this issue Apr 23, 2021 · 0 comments

Comments

@justin-calleja
Copy link

justin-calleja commented Apr 23, 2021

First time coming across tslib in this project (thanks). From its README:

This is a runtime library for TypeScript that contains all of the TypeScript helper functions.

For optimized bundles with TypeScript, you should absolutely consider using tslib and --importHelpers.

So it seems like the existing package.json for this project should be updated to put tslib under dependencies (not devDependencies), and that tsconfig.json should have importHelpers uncommented to set it to true.

Would probably add some docs in README.md to the effect that e.g. if your lib is small (e.g. you only have one module), then you're better off just removing tslib and the importHelpers option.

What do you think? Do you want a PR for this?

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant