From e1b4d5a66522c04ebe429a1a14d3a31e06db4b0b Mon Sep 17 00:00:00 2001 From: lyutails Date: Wed, 15 Nov 2023 00:47:44 +0300 Subject: [PATCH 1/7] feat: subtract points if pr does not follow guideline --- react/modules/module03/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/react/modules/module03/README.md b/react/modules/module03/README.md index e81133f2d..26bef012c 100644 --- a/react/modules/module03/README.md +++ b/react/modules/module03/README.md @@ -89,6 +89,7 @@ Run app and check that the functionality is working (cross-check) - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Test coverage is less than 80%: **-30 points** - Commits after the deadline: **-40 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** ### Repository requirements From 7391b39d2bd3519517a9452eeb463af026053899 Mon Sep 17 00:00:00 2001 From: lyutails Date: Wed, 15 Nov 2023 00:48:36 +0300 Subject: [PATCH 2/7] feat: subtract points if pr does not follow guideline module 01 --- react/modules/module01/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/react/modules/module01/README.md b/react/modules/module01/README.md index e4b148406..e44e59a6b 100644 --- a/react/modules/module01/README.md +++ b/react/modules/module01/README.md @@ -97,6 +97,7 @@ Run app and check that the functionality is working (cross-check) - Presence of _code-smells_ (God-object, chunks of duplicate code), commented code sections: **-10 points per each** - Usage of Redux or other state management libraries: **-100 points** - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** ### Repository requirements From 827eb0570568b87fb33617070f86508a522bfe87 Mon Sep 17 00:00:00 2001 From: lyutails Date: Wed, 15 Nov 2023 00:49:57 +0300 Subject: [PATCH 3/7] feat: subtract points if pr does not follow guideline module 02 --- react/modules/module02/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/react/modules/module02/README.md b/react/modules/module02/README.md index 446ec02f9..c759297f5 100644 --- a/react/modules/module02/README.md +++ b/react/modules/module02/README.md @@ -84,6 +84,7 @@ A student can achieve a maximum of 100 points. - Usage of Redux or other state management libraries: **-100 points** - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Commits after the deadline: **-40 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** ### Repository Requirements From 2f199715ae7ea6462940afba9a8f5c0a5bfbcc6b Mon Sep 17 00:00:00 2001 From: lyutails Date: Wed, 15 Nov 2023 00:50:49 +0300 Subject: [PATCH 4/7] feat: subtract points if pr does not follow guideline module 04 --- react/modules/module04/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/react/modules/module04/README.md b/react/modules/module04/README.md index ca3665969..ca2e0ab8f 100644 --- a/react/modules/module04/README.md +++ b/react/modules/module04/README.md @@ -74,6 +74,7 @@ Run app and check that the functionality is working (cross-check) - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Test coverage is less than 80%: **-30 points** - Commits after the deadline: **-40 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** ### Repository requirements From fd330918c0f7b506c7bd51da654c6a88dec28748 Mon Sep 17 00:00:00 2001 From: lyutails Date: Wed, 15 Nov 2023 00:52:07 +0300 Subject: [PATCH 5/7] feat: subtract points if pr does not follow guideline module 05 --- react/modules/module05/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/react/modules/module05/README.md b/react/modules/module05/README.md index d5f03b6f6..4ec50edd3 100644 --- a/react/modules/module05/README.md +++ b/react/modules/module05/README.md @@ -72,6 +72,7 @@ Run app and check that the functionality is working (cross-check) - Usage of client state on page: **-20 points** per each - Pages API isn't used: **-50 points** - Commits after the deadline: **-40 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** ### Repository requirements From aa2b12a186e23d27c03d20061d8bc52e854623db Mon Sep 17 00:00:00 2001 From: lyutails Date: Wed, 15 Nov 2023 09:07:38 +0300 Subject: [PATCH 6/7] fix: reformulated --- react/modules/module01/README.md | 2 +- react/modules/module02/README.md | 2 +- react/modules/module03/README.md | 2 +- react/modules/module04/README.md | 2 +- react/modules/module05/README.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/react/modules/module01/README.md b/react/modules/module01/README.md index e44e59a6b..7f159c366 100644 --- a/react/modules/module01/README.md +++ b/react/modules/module01/README.md @@ -97,7 +97,7 @@ Run app and check that the functionality is working (cross-check) - Presence of _code-smells_ (God-object, chunks of duplicate code), commented code sections: **-10 points per each** - Usage of Redux or other state management libraries: **-100 points** - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** -- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** +- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** ### Repository requirements diff --git a/react/modules/module02/README.md b/react/modules/module02/README.md index c759297f5..2c6cd0a27 100644 --- a/react/modules/module02/README.md +++ b/react/modules/module02/README.md @@ -84,7 +84,7 @@ A student can achieve a maximum of 100 points. - Usage of Redux or other state management libraries: **-100 points** - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Commits after the deadline: **-40 points** -- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** +- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** ### Repository Requirements diff --git a/react/modules/module03/README.md b/react/modules/module03/README.md index 26bef012c..46fda55fa 100644 --- a/react/modules/module03/README.md +++ b/react/modules/module03/README.md @@ -89,7 +89,7 @@ Run app and check that the functionality is working (cross-check) - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Test coverage is less than 80%: **-30 points** - Commits after the deadline: **-40 points** -- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** +- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** ### Repository requirements diff --git a/react/modules/module04/README.md b/react/modules/module04/README.md index ca2e0ab8f..619f8b67f 100644 --- a/react/modules/module04/README.md +++ b/react/modules/module04/README.md @@ -74,7 +74,7 @@ Run app and check that the functionality is working (cross-check) - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Test coverage is less than 80%: **-30 points** - Commits after the deadline: **-40 points** -- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** +- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** ### Repository requirements diff --git a/react/modules/module05/README.md b/react/modules/module05/README.md index 4ec50edd3..eb71a605a 100644 --- a/react/modules/module05/README.md +++ b/react/modules/module05/README.md @@ -72,7 +72,7 @@ Run app and check that the functionality is working (cross-check) - Usage of client state on page: **-20 points** per each - Pages API isn't used: **-50 points** - Commits after the deadline: **-40 points** -- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) : **-10 points** +- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** ### Repository requirements From 9be9560be5ba9280c9cbbc5a7bdc504d807ece1c Mon Sep 17 00:00:00 2001 From: lyutails Date: Wed, 15 Nov 2023 23:40:19 +0300 Subject: [PATCH 7/7] feat: change back to how it was previously formulated on first run --- react/modules/graphiql.md | 1 + react/modules/module01/README.md | 2 +- react/modules/module02/README.md | 2 +- react/modules/module03/README.md | 2 +- react/modules/module04/README.md | 2 +- react/modules/module05/README.md | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/react/modules/graphiql.md b/react/modules/graphiql.md index 32c009f90..abd7a496f 100644 --- a/react/modules/graphiql.md +++ b/react/modules/graphiql.md @@ -177,4 +177,5 @@ For the convenience of verification, it is **necessary** to record and post on Y - [ ] Absence of prettier **-100 points** - [ ] Absence of husky git hooks **-100 points** - [ ] Usage 3rd party / open source libraries for prettifying, i18n **-150 points** +- [ ] Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following): **-10 points** - [ ] The administration reserves the right to apply penalties for the use of incorrect repository or branch names diff --git a/react/modules/module01/README.md b/react/modules/module01/README.md index 7f159c366..aa179ea47 100644 --- a/react/modules/module01/README.md +++ b/react/modules/module01/README.md @@ -97,7 +97,7 @@ Run app and check that the functionality is working (cross-check) - Presence of _code-smells_ (God-object, chunks of duplicate code), commented code sections: **-10 points per each** - Usage of Redux or other state management libraries: **-100 points** - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** -- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following): **-10 points** ### Repository requirements diff --git a/react/modules/module02/README.md b/react/modules/module02/README.md index 2c6cd0a27..b26350ba8 100644 --- a/react/modules/module02/README.md +++ b/react/modules/module02/README.md @@ -84,7 +84,7 @@ A student can achieve a maximum of 100 points. - Usage of Redux or other state management libraries: **-100 points** - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Commits after the deadline: **-40 points** -- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following): **-10 points** ### Repository Requirements diff --git a/react/modules/module03/README.md b/react/modules/module03/README.md index 46fda55fa..117940e73 100644 --- a/react/modules/module03/README.md +++ b/react/modules/module03/README.md @@ -89,7 +89,7 @@ Run app and check that the functionality is working (cross-check) - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Test coverage is less than 80%: **-30 points** - Commits after the deadline: **-40 points** -- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following): **-10 points** ### Repository requirements diff --git a/react/modules/module04/README.md b/react/modules/module04/README.md index 619f8b67f..09f2e6bc3 100644 --- a/react/modules/module04/README.md +++ b/react/modules/module04/README.md @@ -74,7 +74,7 @@ Run app and check that the functionality is working (cross-check) - Usage of component libraries, e.g. Material UI, Ant Design: **-100 points** - Test coverage is less than 80%: **-30 points** - Commits after the deadline: **-40 points** -- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following): **-10 points** ### Repository requirements diff --git a/react/modules/module05/README.md b/react/modules/module05/README.md index eb71a605a..4e1197e8c 100644 --- a/react/modules/module05/README.md +++ b/react/modules/module05/README.md @@ -72,7 +72,7 @@ Run app and check that the functionality is working (cross-check) - Usage of client state on page: **-20 points** per each - Pages API isn't used: **-50 points** - Commits after the deadline: **-40 points** -- Failure to meet the [requirements](https://docs.rs.school/#/pull-request-review-process?id=%d0%a2%d1%80%d0%b5%d0%b1%d0%be%d0%b2%d0%b0%d0%bd%d0%b8%d1%8f-%d0%ba-pull-request-pr) when creating a Pull Request (including checkboxes in Score): **-10 points** +- Pull Request doesn't follow guideline (including checkboxes in Score) [PR example](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following): **-10 points** ### Repository requirements