From 338e5adfd1e6478a1db661bfdad63049b3d67d73 Mon Sep 17 00:00:00 2001 From: Vitalii Rogozin Date: Sat, 16 Nov 2024 22:48:19 +0500 Subject: [PATCH 1/2] docs: update christmas-shop task --- tasks/christmas-shop/christmas-shop-part3.md | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tasks/christmas-shop/christmas-shop-part3.md b/tasks/christmas-shop/christmas-shop-part3.md index f5ba4911f..e9c83db6b 100644 --- a/tasks/christmas-shop/christmas-shop-part3.md +++ b/tasks/christmas-shop/christmas-shop-part3.md @@ -39,14 +39,15 @@ In this part of the task, you need to add the following functionality to the web ### CrossCheck Criteria (90 points) -1. Implementation of the **burger menu** on both pages: **+22** +1. Implementation of the **burger menu** on both pages: **+20** - At a page width of 768px and less, the navigation panel hides, and the burger icon appears: **+2** - - When clicking the burger icon, the burger menu slides out from the right, and the burger icon smoothly transforms into a cross: **+4** + - When clicking the burger icon, the burger menu slides out from the right, and the burger icon smoothly transforms into a cross: **+2** - The burger menu occupies the entire available screen area below the `
` block: **+2** - - When clicking the cross, the burger menu smoothly hides, moving to the right of the screen, and the cross smoothly transforms into a burger icon: **+4** + - When clicking the cross, the burger menu smoothly hides, moving to the right of the screen, and the cross smoothly transforms into a burger icon: **+2** - The burger icon is created using HTML and CSS without the use of images/svg: **+2** - Links in the burger menu work, providing smooth scrolling to anchor points: **+2** - - When clicking on any link (interactive or non-interactive) in the menu, the burger menu smoothly hides to the right, and the cross smoothly transforms into a burger icon: **+2** + - When clicking on any link (interactive or non-interactive) in the menu, the burger menu hides, and the cross transforms into a burger icon: **+2** + - When clicking on any link (interactive or non-interactive) in the menu, the burger menu smoothly hides to the right, and the cross smoothly transforms into a burger icon if a user stays on the same page: **+2** - The placement and sizes of elements in the burger menu correspond to the layout (horizontal and vertical centering of menu items): **+2** - When the page width increases to 769px and larger, the burger icon and the open burger menu hide, and the navigation panel appears: **+2** 2. Implementation of the **Slider** on the `home` page: **+18** @@ -54,19 +55,20 @@ In this part of the task, you need to add the following functionality to the web - The left arrow button is inactive at the far left position of the slider: **+2** - The right arrow button is inactive at the far right position of the slider: **+2** - Scrolling the slider is accompanied by like the carousel animation (the method of animation execution is not verified): **+4** - - The slider is fully scrolled with 3 presses of the arrow button in one direction for screen widths of 768px and larger, and with 6 presses of the arrow button in one direction for screen widths of 767px and less: **+8** + - The slider is fully scrolled with 3 presses of the arrow button in one direction for screen widths of 769px and larger, and with 6 presses of the arrow button in one direction for screen widths of 768px and less: **+8** 3. Implementation of the **Timer** on the `home` page: **+8** - The timer shows the correct value of the remaining days, hours, minutes, and seconds until the New Year in `UTC+0`: **+2** - Leading zeros are not displayed for single-digit numbers: **+2** - The timer updates every second, displaying the current remaining time with the labels `days`, `hours`, `minutes`, `seconds` (the labels must not change): **+4** 4. When opening and refreshing the page, 4 random cards are displayed in the block **Best Gifts** on the `home` page: **+4** -5. Implementation of the **Category switching** for products on the `gifts` page: **+6** +5. Implementation of the **Category switching** for products on the `gifts` page: **+8** - The **ALL** category is active and all gifts are displayed when opening or reloading the `gifts` page: **+2** - When switching categories, the gifts of the selected category are displayed: **+4** + - Only the selected category tab is active: **+2** 6. Implementation of the **Button UP** on the `gifts` page: **+14** - The button can only appear at a screen width of 768px and less: **+4** - At the top of the page, the button is not displayed: **+4** - - The button appears after scrolling the page down: **+4** + - The button appears after scrolling the page down by 300px: **+4** - When the button is clicked, the page scrolls to the top: **+2** 7. Implementation of the **Modal** for selected gift on both pages: **+18** - The Modal with the description of a specific gift opens when clicking on any part of a card of gift: **+4** From 4d5e5a55bb3c8930ae82e90525e038ca12307285 Mon Sep 17 00:00:00 2001 From: Vitalii Rogozin <73646765+WiiJoy@users.noreply.github.com> Date: Sat, 16 Nov 2024 23:16:19 +0500 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Meg G. <146496794+stardustmeg@users.noreply.github.com> --- tasks/christmas-shop/christmas-shop-part3.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tasks/christmas-shop/christmas-shop-part3.md b/tasks/christmas-shop/christmas-shop-part3.md index e9c83db6b..9c2f2a74d 100644 --- a/tasks/christmas-shop/christmas-shop-part3.md +++ b/tasks/christmas-shop/christmas-shop-part3.md @@ -49,13 +49,13 @@ In this part of the task, you need to add the following functionality to the web - When clicking on any link (interactive or non-interactive) in the menu, the burger menu hides, and the cross transforms into a burger icon: **+2** - When clicking on any link (interactive or non-interactive) in the menu, the burger menu smoothly hides to the right, and the cross smoothly transforms into a burger icon if a user stays on the same page: **+2** - The placement and sizes of elements in the burger menu correspond to the layout (horizontal and vertical centering of menu items): **+2** - - When the page width increases to 769px and larger, the burger icon and the open burger menu hide, and the navigation panel appears: **+2** + - When the page width increases more than 768px, the burger icon and the open burger menu hide, and the navigation panel appears: **+2** 2. Implementation of the **Slider** on the `home` page: **+18** - Scrolling the slider in the corresponding direction is implemented by pressing left arrow button and right arrow button: **+2** - The left arrow button is inactive at the far left position of the slider: **+2** - The right arrow button is inactive at the far right position of the slider: **+2** - - Scrolling the slider is accompanied by like the carousel animation (the method of animation execution is not verified): **+4** - - The slider is fully scrolled with 3 presses of the arrow button in one direction for screen widths of 769px and larger, and with 6 presses of the arrow button in one direction for screen widths of 768px and less: **+8** + - Scrolling the slider is accompanied by the carousel-like animation (the method of animation execution is not verified): **+4** + - The slider is fully scrolled with 3 presses of the arrow button in one direction for screen widths more than 768px, and with 6 presses of the arrow button in one direction for screen widths of 768px and less: **+8** 3. Implementation of the **Timer** on the `home` page: **+8** - The timer shows the correct value of the remaining days, hours, minutes, and seconds until the New Year in `UTC+0`: **+2** - Leading zeros are not displayed for single-digit numbers: **+2** @@ -65,7 +65,7 @@ In this part of the task, you need to add the following functionality to the web - The **ALL** category is active and all gifts are displayed when opening or reloading the `gifts` page: **+2** - When switching categories, the gifts of the selected category are displayed: **+4** - Only the selected category tab is active: **+2** -6. Implementation of the **Button UP** on the `gifts` page: **+14** +6. Implementation of the **Scroll-to-Top** button on the `gifts` page: **+14** - The button can only appear at a screen width of 768px and less: **+4** - At the top of the page, the button is not displayed: **+4** - The button appears after scrolling the page down by 300px: **+4**